Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flake: add more packages to dev shell #656

Merged
merged 1 commit into from
Jul 1, 2024
Merged

flake: add more packages to dev shell #656

merged 1 commit into from
Jul 1, 2024

Conversation

Freax13
Copy link
Contributor

@Freax13 Freax13 commented Jul 1, 2024

These packages are used in some Just targets. To make onboarding easier they should be part of the devshell.

@Freax13
flake: add more packages to devshell
044ae25 
These packages are used in some Just targets. To make onboarding easier
they should be part of the devshell.
@Freax13 Freax13 requested a review from katexochen as a code owner July 1, 2024 10:56
@CLAassistant
Copy link

CLAassistant commented Jul 1, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Freax13 Freax13 added the no changelog PRs not listed in the release notes label Jul 1, 2024
katexochen
katexochen approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@katexochen katexochen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to add more to our dev shell, we might want a second shell for CI runs or pick the required dependencies per-job so we don't have to download stuff we don't need.

@Freax13 Freax13 merged commit 223d696 into main Jul 1, 2024
8 of 9 checks passed
@Freax13 Freax13 deleted the freax13/nix-devshell branch July 1, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katexochen katexochen katexochen approved these changes

Assignees
No one assigned
Labels
no changelog PRs not listed in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Freax13 @CLAassistant @katexochen