Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: use manifest reference values for attestation #608

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

davidweisse
Copy link
Contributor

This changes the Coordinator validate options to use the reference values from the local manifest in the set and verify command. The verify command takes an additional flag --manifest for this to provide the path to the manifest.

The default workspace directory for the verify command is no longer ./verify, because the manifest lies in the current directory. Instead, the output files for the verify command are always written to the verify directory in the current workspace directory.

@davidweisse davidweisse added the changelog PRs that should be part of the release notes label Jun 20, 2024
@davidweisse davidweisse marked this pull request as ready for review June 20, 2024 10:00
@msanft
Copy link
Contributor

msanft commented Jun 20, 2024

Could you make it so that runtimeHandler is not passed to the CLI in the build process anymore, but deduced from the trusted measurement too?

@katexochen
Copy link
Member

Could you make it so that runtimeHandler is not passed to the CLI in the build process anymore, but deduced from the trusted measurement too?

Should be done in a separate PR.

@davidweisse davidweisse force-pushed the dav/use-manifest-ref-values branch from 593ea8c to 6ccecdb Compare June 20, 2024 15:00
@davidweisse davidweisse requested a review from burgerdev June 20, 2024 15:00
Copy link
Contributor

@burgerdev burgerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should follow up with

  1. A documentation change mentioning the manifest flag.
  2. verify should fail if the given manifest is not latest.
  3. Tests for SNPValidateOpts.

@davidweisse davidweisse merged commit 3038343 into main Jun 21, 2024
8 checks passed
@davidweisse davidweisse deleted the dav/use-manifest-ref-values branch June 21, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog PRs that should be part of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants