logging: enable subsystem warn level by default #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidweisse
force-pushed
the
dav/activate-snp-logging
branch
from
aa29f85 to
743f383
Compare
|
@katexochen I wonder if we should enable all log subsystems at WARN level by default, and then ensure some rigour so that actually relevant messages (and only those) are reported at that level. |
katexochen
reviewed
Jun 13, 2024
Fine for me! :) |
davidweisse
force-pushed
the
dav/activate-snp-logging
branch
from
743f383 to
2ecf136
Compare
burgerdev
approved these changes
Jun 13, 2024
katexochen
added
changelog
|
@davidweisse could you update PR title and description? |
davidweisse
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the all log subsystems at
warnlevel or above. These logs will be get printed regardless of theCONTRAST_LOG_SUBSYSTEMSlist. TheCONTRAST_LOG_LEVELvariable is also considered, so when the global log level is set toerror, only error messages will get printed from the subsystems