coordinator: implement history with fs store backend #522
Conversation
Signed-off-by: Paul Meyer <[email protected]>
| } | ||
|
|
||
| // GetLatest returns the verified transition for the given hash. | ||
| func (h *History) GetLatest() (*LatestTransition, error) { |
There was a problem hiding this comment.
While implementing I realized that I need to be able to tell the difference between generic errors and "no latest set".
There was a problem hiding this comment.
The issue is that I'd like to update my local state from persistency before handling a SetManifest, when I don't yet have something to CompareAndSet. But I can work around that by ignoring errors when my local state suggests emptiness - I will be stopped at the very latest when my update conflicts. So this would be a good extension, but not necessary right now.
There was a problem hiding this comment.
use errors.Is(err, os.ErrNotExist) ?
There was a problem hiding this comment.
I can do that for now, but it's somewhat counter to the idea of having pluggable KV stores :)
This is the history storage module and part of the implementation of RFC 004.