Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: inject initializer with contrast generate #510

Merged
merged 4 commits into from
Jun 4, 2024

Conversation

davidweisse
Copy link
Contributor

@davidweisse davidweisse commented May 28, 2024

The generate command will now automatically inject the Initializer init container to all resources with the contrast-cc runtime. This can be disabled by either specifying the --skip-initializer flag when calling generate, or with the contrast.edgeless.systems/skip-initializer annotation set to "true" for a specific resource.

Release run: https://github.com/edgelesssys/contrast/actions/runs/9350903637

@davidweisse davidweisse requested a review from burgerdev May 28, 2024 09:54
@davidweisse davidweisse added the feature Shiny new feature for our users label May 28, 2024
Copy link

github-actions bot commented May 28, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-06-04 14:33 UTC

@katexochen katexochen changed the title cli: add initializer injection cli: inject initializer with contrast generate May 28, 2024
Copy link
Contributor

@burgerdev burgerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Do you want to add the image replacements file to the released artifact in a future PR?

docs/docs/components/service-mesh.md Outdated Show resolved Hide resolved
internal/kuberesource/mutators.go Outdated Show resolved Hide resolved
internal/kuberesource/mutators.go Outdated Show resolved Hide resolved
@davidweisse davidweisse force-pushed the feat/inject-initializer branch from cf90fcb to b195d5f Compare May 28, 2024 14:50
@davidweisse
Copy link
Contributor Author

Thanks! Do you want to add the image replacements file to the released artifact in a future PR?

I'll add the changes to the release artifacts here. I'll probably open a separate PR on this branch.

@davidweisse davidweisse force-pushed the feat/inject-initializer branch from db629c5 to a393a0a Compare May 31, 2024 07:18
@davidweisse davidweisse marked this pull request as ready for review May 31, 2024 07:30
@davidweisse davidweisse requested a review from katexochen as a code owner May 31, 2024 07:30
@davidweisse davidweisse requested a review from burgerdev May 31, 2024 07:30
internal/kuberesource/mutators.go Outdated Show resolved Hide resolved
internal/kuberesource/mutators_test.go Outdated Show resolved Hide resolved
@davidweisse davidweisse force-pushed the feat/inject-initializer branch 2 times, most recently from c22d65b to acce2e8 Compare May 31, 2024 09:28
cli/cmd/generate.go Outdated Show resolved Hide resolved
cli/cmd/generate.go Outdated Show resolved Hide resolved
cli/cmd/generate.go Outdated Show resolved Hide resolved
cli/cmd/generate.go Outdated Show resolved Hide resolved
docs/docs/components/service-mesh.md Outdated Show resolved Hide resolved
docs/docs/deployment.md Outdated Show resolved Hide resolved
docs/docs/deployment.md Outdated Show resolved Hide resolved
internal/kuberesource/mutators.go Outdated Show resolved Hide resolved
internal/kuberesource/mutators.go Outdated Show resolved Hide resolved
@katexochen
Copy link
Member

We also need to update the emojivoto demo docs.

@davidweisse davidweisse force-pushed the feat/inject-initializer branch from acce2e8 to 9af55e0 Compare June 3, 2024 13:06
@davidweisse davidweisse requested a review from katexochen June 3, 2024 13:28
@davidweisse davidweisse merged commit b706906 into main Jun 4, 2024
14 checks passed
@davidweisse davidweisse deleted the feat/inject-initializer branch June 4, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Shiny new feature for our users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants