coordinator: make metrics endpoint configurable #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
davidweisse
force-pushed
the
feat/coordinator-optional-metrics
branch
2 times, most recently
from
018ed18 to
83fb938
Compare
burgerdev
reviewed
May 27, 2024
davidweisse
force-pushed
the
feat/coordinator-optional-metrics
branch
from
83fb938 to
4864464
Compare
katexochen
reviewed
May 27, 2024
davidweisse
force-pushed
the
feat/coordinator-optional-metrics
branch
from
4864464 to
c34e4b3
Compare
katexochen
approved these changes
May 28, 2024
| @@ -96,6 +96,7 @@ func (ct *ContrastTest) Init(t *testing.T, resources []any) { | |||
| resources = kuberesource.PatchImages(resources, ct.ImageReplacements) | |||
| resources = kuberesource.PatchNamespaces(resources, ct.Namespace) | |||
| resources = kuberesource.PatchServiceMeshAdminInterface(resources, 9901) | |||
| resources = kuberesource.PatchCoordinatorMetrics(resources, 9102) | |||
There was a problem hiding this comment.
Not sure about patching this within contrasttest. We might want to add a test case where we disable the metrics endpoint to check it is actually not reachable. Same for the envoy admin iface or other config things. Any thoughts on this @burgerdev ?
Anyway, nothing we must address in this PR.
There was a problem hiding this comment.
I agree: we should eventually test these scenarios, but until then we can leave it here.
burgerdev
approved these changes
May 29, 2024
davidweisse
force-pushed
the
feat/coordinator-optional-metrics
branch
from
c34e4b3 to
0c5d008
Compare
davidweisse
force-pushed
the
feat/coordinator-optional-metrics
branch
from
0c5d008 to
a4a73d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the Coordinator metrics endpoint configurable via an environment variable. If
CONTRAST_METRICS_PORTis set, the metrics server will start on that port. If the variable is not set, the metrics server will not start.For CI, the endpoint is activated through the
PatchCoordinatorMetricsfunction.