snp: cache amd kds requests #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katexochen
requested changes
Jan 2, 2024
3u13r
force-pushed
the
feat/snp/cache-kds
branch
from
d8ca043 to
f38078f
Compare
katexochen
reviewed
Jan 2, 2024
katexochen
approved these changes
Jan 2, 2024
3u13r
force-pushed
the
feat/snp/cache-kds
branch
from
a94b0e6 to
e6552f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From non-scientific observation, this greatly improves start-up time of workloads. This also mitigates "unnecessary" KDS requests when there is no manifest set.
With this (simplest) implementation, we currently cache all requests made by the library during verify. We should discuss reducing that to the /vcek/ endpoint or even the first endpoint mentioned in Chapter 4 Table 10 here: https://www.amd.com/content/dam/amd/en/documents/epyc-technical-docs/specifications/57230.pdf.