Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add {Metal,K3s}-QEMU-SNP-GPU platforms #1091

Merged
merged 5 commits into from
Jan 3, 2025
Merged

Add {Metal,K3s}-QEMU-SNP-GPU platforms #1091

merged 5 commits into from
Jan 3, 2025

Conversation

msanft
Copy link
Contributor

@msanft msanft commented Dec 19, 2024

This adds a new K3s-QEMU-SNP-GPU platform that can be used for testing GPU-specific features on our on-prem infrastructure that uses this setup. This intentionally does not yet add any specific actions done if that platform is selected.

@msanft msanft added the no changelog PRs not listed in the release notes label Dec 19, 2024
@msanft msanft force-pushed the msanft/k3s-qemu-gpu-platform branch 2 times, most recently from e535a27 to 1fb5838 Compare December 19, 2024 13:38
@msanft msanft mentioned this pull request Dec 19, 2024
Closed
@katexochen
Copy link
Member

I thinks this should also add Metal-QEMU-SNP-GPU at the same time, which I expect to be needed.

@msanft
Copy link
Contributor Author

msanft commented Dec 20, 2024

I thinks this should also add Metal-QEMU-SNP-GPU at the same time, which I expect to be needed.

My initial thought was to split these to keep a minimal diff, but I also think combining these will make sense. Will do so!

@msanft msanft changed the title Add K3s-QEMU-SNP-GPU platform Add {Metal,K3s}-QEMU-SNP-GPU platforms Dec 20, 2024
@katexochen katexochen added the needs: rework PR author needs to work in feedback label Dec 27, 2024
@msanft msanft force-pushed the msanft/k3s-qemu-gpu-platform branch from 5b7e240 to cf5d659 Compare December 30, 2024 12:11
@msanft msanft removed the needs: rework PR author needs to work in feedback label Dec 30, 2024
@msanft msanft requested a review from katexochen December 30, 2024 12:11
@msanft msanft force-pushed the msanft/k3s-qemu-gpu-platform branch 2 times, most recently from 601d765 to c02463e Compare December 30, 2024 12:23
@katexochen
Copy link
Member

Please also update .github/workflows/release.yml L301 so the runtime.yml is published for these platforms.

@msanft msanft force-pushed the msanft/k3s-qemu-gpu-platform branch from c02463e to 531728d Compare December 30, 2024 13:23
@msanft
Copy link
Contributor Author

msanft commented Dec 30, 2024 •
edited
Loading

Please also update .github/workflows/release.yml L301 so the runtime.yml is published for these platforms.

Done :)

@msanft msanft force-pushed the msanft/k3s-qemu-gpu-platform branch from 531728d to 3dd6cab Compare January 2, 2025 07:28
@katexochen
Copy link
Member

katexochen commented Jan 2, 2025 •
edited by msanft
Loading

We also need to update

  • packages/contrast-releases.nix
  • packages/update-contrast-releases.sh

@msanft msanft force-pushed the msanft/k3s-qemu-gpu-platform branch 2 times, most recently from 0cb6672 to b6a0e6d Compare January 2, 2025 08:05
@katexochen
Copy link
Member

Release fails on this state: https://github.com/edgelesssys/contrast/actions/runs/12580504016/job/35062540645

@katexochen
Copy link
Member

opened #1114

@katexochen
Copy link
Member

still failing: https://github.com/edgelesssys/contrast/actions/runs/12581815191/job/35066296786

katexochen
katexochen reviewed Jan 2, 2025
View reviewed changes
packages/scripts.nix Outdated Show resolved Hide resolved
@msanft msanft force-pushed the msanft/k3s-qemu-gpu-platform branch from b6a0e6d to 962eadc Compare January 2, 2025 12:18
@msanft msanft requested a review from katexochen January 2, 2025 12:24
@msanft msanft force-pushed the msanft/k3s-qemu-gpu-platform branch from 962eadc to 0222192 Compare January 2, 2025 14:05
msanft added 5 commits January 2, 2025 15:06
@msanft
Add K3s-QEMU-SNP-GPU platform
5994988 
This adds a new `K3s-QEMU-SNP-GPU` platform that can be used for testing GPU-specific features on our on-prem infrastructure that uses this setup. This intentionally does not yet add any specific actions done if that platform is selected.
@msanft
node-installer: pass through CDI annotations
4487f9a 
For GPU support, Kata needs CDI pod annotations. We need to configure containerd to pass these through to Kata.
@msanft
node-installer: add GPU-specific options
55abfe4
@msanft
Add Metal-QEMU-SNP-GPU platform
01648cd 
This adds a new `Metal-QEMU-SNP-GPU` platform that can be used for testing GPU-specific features on Scaleway and other non-K3s environments. This intentionally does not yet add any specific actions done if that platform is selected.
@msanft
node-installer: correctly name test-cases
e5f11fe
@msanft msanft force-pushed the msanft/k3s-qemu-gpu-platform branch from 0222192 to e5f11fe Compare January 2, 2025 14:06
@msanft
Copy link
Contributor Author

msanft commented Jan 2, 2025 •
edited
Loading

Release works correctly now. Can be verified here: https://github.com/edgelesssys/contrast/blob/4f89ee2ad2987f8f10d69f9bb1c497b3c4cb4e5c/packages/contrast-releases.json

@katexochen katexochen added this to the v1.3.0 milestone Jan 3, 2025
@msanft msanft merged commit 28d72cc into main Jan 3, 2025
16 of 18 checks passed
@msanft msanft deleted the msanft/k3s-qemu-gpu-platform branch January 3, 2025 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katexochen katexochen katexochen approved these changes

@burgerdev burgerdev Awaiting requested review from burgerdev burgerdev is a code owner

Assignees
No one assigned
Labels
no changelog PRs not listed in the release notes
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@msanft @katexochen