Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate the coordinator's policy in set phase #105

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

burgerdev
Copy link
Contributor

No description provided.

cli/set.go Outdated Show resolved Hide resolved
@burgerdev burgerdev force-pushed the burgerdev/verify-coord branch 3 times, most recently from b10890a to 8ed2c56 Compare January 30, 2024 15:34
@burgerdev burgerdev marked this pull request as ready for review January 30, 2024 15:36
@burgerdev
Copy link
Contributor Author

@katexochen PTAL again.

@burgerdev burgerdev force-pushed the burgerdev/verify-coord branch from 8ed2c56 to c20f5ba Compare January 30, 2024 15:37
Copy link
Member

@katexochen katexochen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general, some nits.

cli/set.go Outdated Show resolved Hide resolved
justfile Outdated Show resolved Hide resolved
packages/default.nix Outdated Show resolved Hide resolved
@burgerdev burgerdev force-pushed the burgerdev/verify-coord branch from 7b952c8 to 3207295 Compare January 31, 2024 11:57
@burgerdev burgerdev force-pushed the burgerdev/verify-coord branch from 3207295 to e880f92 Compare January 31, 2024 12:03
@burgerdev burgerdev requested a review from katexochen January 31, 2024 12:04
@burgerdev burgerdev merged commit 9ba9775 into main Jan 31, 2024
5 checks passed
@burgerdev burgerdev deleted the burgerdev/verify-coord branch January 31, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants