cli: genpolicy logging: Add debug log level and repository reference to auth failure #1044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burgerdev
reviewed
Dec 2, 2024
packages/by-name/kata/kata-runtime/0017-Include-reference-in-logs-when-auth-failure.patch
Outdated
Show resolved
Hide resolved
katexochen
reviewed
Dec 2, 2024
katexochen
reviewed
Dec 2, 2024
jmxnzo
force-pushed
the
genpolicy-logging-jla
branch
2 times, most recently
from
24984c5 to
c4f9bc9
Compare
katexochen
reviewed
Dec 2, 2024
|
I guess it should also be possible to upstream that patch? |
jmxnzo
force-pushed
the
genpolicy-logging-jla
branch
from
c4f9bc9 to
e94bb43
Compare
I'm going to open an upstream issue and then finish the missing questions in the comment. |
jmxnzo
force-pushed
the
genpolicy-logging-jla
branch
from
e94bb43 to
ab6269d
Compare
katexochen
reviewed
Dec 3, 2024
jmxnzo
force-pushed
the
genpolicy-logging-jla
branch
3 times, most recently
from
c513151 to
583466c
Compare
jmxnzo
force-pushed
the
genpolicy-logging-jla
branch
from
583466c to
0509b20
Compare
jmxnzo
force-pushed
the
genpolicy-logging-jla
branch
from
0509b20 to
a75af8a
Compare
burgerdev
approved these changes
Dec 4, 2024
katexochen
approved these changes
Dec 4, 2024
katexochen
added
changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR includes the debug log level of genpolicy into the Contrast CLI. Thus the resulting mapping is:
Contrast info == Genpolicy warning
Contrast debug == Genpolicy info/debug
As well it patches the existing genpolicy error message in case of an authentication failure, to include the reference to the repository.