Skip to content

Commit

Permalink
node-installer: remove resource limits
Browse files Browse the repository at this point in the history
There's no strong reason for having resource limits on the
node-installer and given the unpredictable nature of the kernel's
resource accounting, we should remove the resource limits so that we
don't run into unexpected OOMs.

Fixes f5da52d

(cherry picked from commit 7f50e0c)

Signed-off-by: Tom Dohrmann <[email protected]>
  • Loading branch information
Freax13 authored and katexochen committed Nov 13, 2024
1 parent 5aae5df commit 5421de4
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions internal/kuberesource/parts.go
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ func NodeInstaller(namespace string, platform platforms.Platform) (*NodeInstalle
WithName("tardev-snapshotter").
WithImage("ghcr.io/edgelesssys/contrast/tardev-snapshotter:latest").
WithResources(ResourceRequirements().
WithMemoryLimitAndRequest(800),
WithMemoryRequest(800),
).
WithVolumeMounts(
VolumeMount().
Expand Down Expand Up @@ -86,7 +86,7 @@ func NodeInstaller(namespace string, platform platforms.Platform) (*NodeInstalle
WithName("nydus-snapshotter").
WithImage("ghcr.io/edgelesssys/contrast/nydus-snapshotter:latest").
WithResources(ResourceRequirements().
WithMemoryLimitAndRequest(800),
WithMemoryRequest(800),
).
WithVolumeMounts(
VolumeMount().
Expand Down Expand Up @@ -158,7 +158,7 @@ func NodeInstaller(namespace string, platform platforms.Platform) (*NodeInstalle
WithName("installer").
WithImage(nodeInstallerImageURL).
WithResources(ResourceRequirements().
WithMemoryLimitAndRequest(100),
WithMemoryRequest(700),
).
WithSecurityContext(SecurityContext().WithPrivileged(true).SecurityContextApplyConfiguration).
WithVolumeMounts(VolumeMount().
Expand Down

0 comments on commit 5421de4

Please sign in to comment.