Don't fail if 'id' is missing from an object. #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msullivan
force-pushed
the
no-require-id
branch
from
7ede9f8
to
596b73f
Compare
The goal here is to give us the freedom to drop 'id' from FreeObject.
msullivan
force-pushed
the
no-require-id
branch
from
596b73f
to
f10f70e
Compare
elprans
approved these changes
Oct 6, 2023
fantix
approved these changes
Oct 12, 2023
fantix
pushed a commit
that referenced
this pull request
Jan 9, 2024
The goal here is to give us the freedom to drop 'id' from FreeObject.
fantix
added a commit
that referenced
this pull request
Jan 9, 2024
Fixes ===== * Fix test that broke due to error message change (#465) (by @msullivan in fed7b24 for #465) * Don't fail if 'id' is missing from an object. (#464) (by @msullivan in be2de71 for #464) * docs: Fix typos is docs (#467) (by @elliotwaite in b4d91b9 for #467) * Fix for Pydantic 2.x (#468) (by @fantix in c6581cb for #468)
Merged
Closed
msullivan
added a commit
to edgedb/edgedb
that referenced
this pull request
Apr 2, 2024
We do this by making FreeObject not extend BaseObject. FreeObject ids are currently generated; this is not particularly useful and requires some machinations to make work correctly. Having FreeObject not have ids makes them more sensible, I think, especially once we are going to support taking them as input. This breaks compatibility but probably not in a way many people depend on. It might require some fixes to bindings. I fixed the python bindings a while ago in prep for this. (edgedb/edgedb-python#464)
msullivan
added a commit
to edgedb/edgedb
that referenced
this pull request
Apr 2, 2024
We do this by making FreeObject not extend BaseObject. FreeObject ids are currently generated; this is not particularly useful and requires some machinations to make work correctly. Having FreeObject not have ids makes them more sensible, I think, especially once we are going to support taking them as input. This breaks compatibility but probably not in a way many people depend on. It might require some fixes to bindings. I fixed the python bindings a while ago in prep for this. (edgedb/edgedb-python#464)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal here is to give us the freedom to drop 'id' from FreeObject.