Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 4 issues in codegen #387

Merged
merged 3 commits into from
Nov 2, 2022
Merged

Fix 4 issues in codegen #387

merged 3 commits into from
Nov 2, 2022

Conversation

fantix
Copy link
Member

@fantix fantix commented Oct 26, 2022 •
edited
Loading

  • Add missing std::json
  • Support optional argument
  • Fix camelcase generation
  • Allow symlinks in project dir

@fantix
Fix 3 issues in codegen
2e311d6 
* Add missing std::json
* Support optional argument
* Fix camelcase generation
@fantix fantix requested a review from 1st1 October 26, 2022 22:57
@1st1
Copy link
Member

1st1 commented Oct 28, 2022

@fantix can you separate the std::json fix into a separate PR? We need to ponder a bit on it.

@fantix fantix marked this pull request as draft October 31, 2022 14:59
@fantix
Copy link
Member Author

fantix commented Oct 31, 2022

can you separate the std::json fix into a separate PR? We need to ponder a bit on it.

@1st1 done in #388

@1st1
Copy link
Member

1st1 commented Nov 1, 2022

Looks good overall, Fantix

@fantix fantix marked this pull request as ready for review November 2, 2022 19:23
@fantix fantix merged commit a912511 into master Nov 2, 2022
@fantix fantix deleted the codegen-fix branch November 2, 2022 20:40
fantix added a commit that referenced this pull request Nov 2, 2022
@fantix
edgedb-python 1.1.0
7d63029 
Codegen Fixes
=============

* Add missing std::json (#387)
* Support optional argument (#387)
* Fix camelcase generation (#387)
* Allow symlinks in project dir (#387)
* Use Executor on generated code for Client/Tx (#390)
@fantix fantix changed the title Fix 3 issues in codegen Fix 4 issues in codegen Nov 2, 2022
@fantix fantix mentioned this pull request Nov 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1st1 1st1 1st1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fantix @1st1