Add with_globals() and friends through state over the protocol
#315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fantix
force-pushed
the
state-over-proto
branch
3 times, most recently
from
e9226a3
to
f7f1f71
Compare
fantix
force-pushed
the
state-over-proto
branch
2 times, most recently
from
db26596
to
b579893
Compare
fantix
force-pushed
the
state-over-proto
branch
2 times, most recently
from
b9d0bef
to
47dd5b9
Compare
This actually drops the custom implementation of SparseObject because the Python binding doesn't need its decoding
Also sync errors
This disallows EdgeQL commands like `configure session`, `set alias`, `set module`, `set global` and their `reset` variants.
Also renamed `session_state_description` to `state_description`.
elprans
approved these changes
Jun 27, 2022
elprans
added a commit
that referenced
this pull request
Jul 21, 2022
Changes ======= * Remove DSN from `create_client()` (by @elprans in 9081105 for #303) * Add support for protocol v1.0 (by @fantix in 51344fe for #306) * improve error when passing empty query arguments (by @nsidnev in 7a393ec) * Accept args in execute() and use the new Execute message (by @fantix in 5298701 for #310) * drop legacy agruments encoding with named tuple codec (by @nsidnev in ef96e76) * Stop using Parse, replace use of headers with fields (by @elprans in b2c9e4b) * Change headers format to str:json (by @fantix in f17a4fd for #319) * Document rolling back a transaction (by @fmoor in 266f18b) * Support EDGEDB_WAIT_UNTIL_AVAILABLE environment variable (by @fmoor in c27ab36) * Add `with_globals()` and friends through state over the protocol (by @fantix in 8582ec1 for #315) * Implement support for range types (by @elprans in a415b9f for #332) * Implement support for cal::date_duration (by @elprans in e77615b for #335) * Recover from failed COMMIT (by @fantix in 9f09e78) * Allow <array<range<T>>> arguments (by @fmoor in 243250c for #351)
Merged
fantix
pushed a commit
that referenced
this pull request
Jul 21, 2022
Changes ======= * Remove DSN from `create_client()` (by @elprans in 9081105 for #303) * Add support for protocol v1.0 (by @fantix in 51344fe for #306) * improve error when passing empty query arguments (by @nsidnev in 7a393ec) * Accept args in execute() and use the new Execute message (by @fantix in 5298701 for #310) * drop legacy agruments encoding with named tuple codec (by @nsidnev in ef96e76) * Stop using Parse, replace use of headers with fields (by @elprans in b2c9e4b) * Change headers format to str:json (by @fantix in f17a4fd for #319) * Document rolling back a transaction (by @fmoor in 266f18b) * Support EDGEDB_WAIT_UNTIL_AVAILABLE environment variable (by @fmoor in c27ab36) * Add `with_globals()` and friends through state over the protocol (by @fantix in 8582ec1 for #315) * Implement support for range types (by @elprans in a415b9f for #332) * Implement support for cal::date_duration (by @elprans in e77615b for #335) * Recover from failed COMMIT (by @fantix in 9f09e78) * Allow <array<range<T>>> arguments (by @fmoor in 243250c for #351)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #310
flagsandcardinalityback to the sparse objectCommandCompleteWithConsequenceand ignore theStateSerializationErrorSET MODULE,SET ALIAS,SET GLOBAL,CONFIGURE SESSION