Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restyle markdown help formatting to not use background colors #453

Merged
merged 1 commit into from
Aug 10, 2021
Merged

Conversation

1st1
Copy link
Member

@1st1 1st1 commented Aug 9, 2021

While there, colorize the "about" section of --help.
The foreground color is also removed in favor of "bold" style.

Fixes #450; superseedes #452.

@1st1 1st1 requested review from tailhook, elprans and fantix August 9, 2021 21:26
@1st1
Copy link
Member Author

1st1 commented Aug 9, 2021

Output:

Screenshot from 2021-08-09 14-27-50

While there, colorize the "about" section of `--help`.

Fixes #450; superseedes #452.
@1st1
Copy link
Member Author

1st1 commented Aug 10, 2021

@tailhook I looked into generalizing this work and making it apply markdown styling after the derive phase, but I don't think it's possible; the problem is that clap::App::about() expects a static lifetime for the about string which I can't figure out how make... I'll merge this as is, but a follow up PR is necessary.

@1st1 1st1 merged commit 0959d78 into master Aug 10, 2021
@1st1 1st1 deleted the mdfix branch August 10, 2021 18:02
@1st1
Copy link
Member Author

1st1 commented Aug 10, 2021

See also clap-rs/clap#2150

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable markdown styling in --help
3 participants