Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: setting the FTUP flag and allocation of TEID #476

Merged
merged 77 commits into from
Dec 4, 2023
Merged

Conversation

arxxm
Copy link
Collaborator

@arxxm arxxm commented Nov 8, 2023

No description provided.

@arxxm arxxm changed the title 120 upf ftup fteid feat: creation of FTUP and allocation of TEID Nov 8, 2023
@arxxm arxxm changed the title feat: creation of FTUP and allocation of TEID feat: setting the FTUP flag and allocation of TEID Nov 8, 2023
@s5uishida
Copy link

s5uishida commented Nov 9, 2023

Hi,

When I applied this Pull Request and tried to work with free5GC, the following error occurred on free5GC.
Also, N3 and N4 are different addresses. I don't think free5GC supports FTUP, so first I tried to confirm the current behavior that is not FTUP.

2023-11-09T10:52:50.787596981+09:00 [INFO][SMF][PduSess] Sending PFCP Session Establishment Request
2023-11-09T10:52:50.788031257+09:00 [INFO][AMF][Gmm][amf_ue_ngap_id:RU:1,AU:1(3GPP)][supi:SUPI:imsi-001010000000000] create smContext[pduSessionID: 1] Success
2023-11-09T10:52:50.800565396+09:00 [WARN][SMF][PFCP] Read PFCP error: None of V4 and V6 flags is set
2023-11-09T10:52:53.793694112+09:00 [WARN][SMF][PFCP] Read PFCP error: None of V4 and V6 flags is set
2023-11-09T10:52:56.806546313+09:00 [WARN][SMF][PFCP] Read PFCP error: None of V4 and V6 flags is set
2023-11-09T10:52:59.791144414+09:00 [WARN][SMF][PduSess] Sending PFCP Session Establishment Request error: Request Transaction [5]: retry-out

FYI.

cmd/core/service/ipam.go Outdated Show resolved Hide resolved
docs/Configuration.md Outdated Show resolved Hide resolved
cmd/core/service/ipam.go Outdated Show resolved Hide resolved
@arxxm
Copy link
Collaborator Author

arxxm commented Nov 25, 2023

Hi,

When I tried with free5GC on 120-upf-ftup-fteid branch, a parsing error occurred regarding the SDF Filter shown by the arrow.

free5GC version used commit:e48e933dde6bad3a83f6cd327003eeba6992abfa (2023.11.03)

Just a quick report.

2023/11/25 20:40:26 INF Got Session Establishment Request from: 192.168.14.141.
2023/11/25 20:40:26 INF 
Session Establishment Request:
  CreatePDR ID: 1 
    Outer Header Removal: 0 
    FAR ID: 1 
    QER ID: 2 
    QER ID: 1 
    URR ID: 1 
    Source Interface: 0 
    TEID: 1 
    Ipv4: 192.168.13.151 
    Ipv6: <nil> 
    UE IPv4 Address: 10.60.0.1 
  CreatePDR ID: 2 
    FAR ID: 2 
    QER ID: 2 
    QER ID: 1 
    URR ID: 1 
    Source Interface: 2 
    UE IPv4 Address: 10.60.0.1 
  CreatePDR ID: 3 
    Outer Header Removal: 0 
    FAR ID: 3 
    QER ID: 1 
    QER ID: 3 
    URR ID: 1 
    Source Interface: 0 
    TEID: 1 
    Ipv4: 192.168.13.151 
    Ipv6: <nil> 
    UE IPv4 Address: 10.60.0.1 
    SDF Filter: permit out ip from 10.60.0.0/16 to any <--
  CreatePDR ID: 4 
    FAR ID: 4 
    QER ID: 1 
    QER ID: 3 
    URR ID: 1 
    Source Interface: 2 
    UE IPv4 Address: 10.60.0.1 
    SDF Filter: permit out ip from any to 10.60.0.0/16 
  CreateFAR ID: 1 
    Apply Action: [2] 
    Forwarding Parameters:
      Network Instance:internet 
  CreateFAR ID: 2 
    Apply Action: [2] 
    Forwarding Parameters:
  CreateFAR ID: 3 
    Apply Action: [2] 
    Forwarding Parameters:
      Network Instance:internet 
  CreateFAR ID: 4 
    Apply Action: [2] 
    Forwarding Parameters:
  CreateQER ID: 3 
    Gate Status DL: 0 
    Gate Status UL: 0 
    QFI: 2 
  CreateQER ID: 2 
    Gate Status DL: 0 
    Gate Status UL: 0 
    QFI: 1 
  CreateQER ID: 1 
    Gate Status DL: 0 
    Gate Status UL: 0 
    Max Bitrate DL: 1000000 
    Max Bitrate UL: 1000000 
    QFI: 0 
  CreateURR ID: 1 
    Measurement Method: 2 
    Volume Threshold: &{Flags:6 TotalVolume:0 UplinkVolume:1000 DownlinkVolume:1000} 
  CreateURR ID: 2 
    Measurement Method: 2 
    Volume Threshold: &{Flags:6 TotalVolume:0 UplinkVolume:1000 DownlinkVolume:1000} 

2023/11/25 20:40:26 INF WARN: No OuterHeaderCreation
2023/11/25 20:40:26 INF Saving FAR info to session: 1, {Action:2 OuterHeaderCreation:0 Teid:0 RemoteIP:0 LocalIP:2534254784 TransportLevelMarking:0}
2023/11/25 20:40:26 INF WARN: No OuterHeaderCreation
2023/11/25 20:40:26 INF Saving FAR info to session: 2, {Action:2 OuterHeaderCreation:0 Teid:0 RemoteIP:0 LocalIP:2534254784 TransportLevelMarking:0}
2023/11/25 20:40:26 INF WARN: No OuterHeaderCreation
2023/11/25 20:40:26 INF Saving FAR info to session: 3, {Action:2 OuterHeaderCreation:0 Teid:0 RemoteIP:0 LocalIP:2534254784 TransportLevelMarking:0}
2023/11/25 20:40:26 INF WARN: No OuterHeaderCreation
2023/11/25 20:40:26 INF Saving FAR info to session: 4, {Action:2 OuterHeaderCreation:0 Teid:0 RemoteIP:0 LocalIP:2534254784 TransportLevelMarking:0}
2023/11/25 20:40:26 INF Saving QER info to session: 3, {GateStatusUL:0 GateStatusDL:0 Qfi:2 MaxBitrateUL:0 MaxBitrateDL:0 StartUL:0 StartDL:0}
2023/11/25 20:40:26 INF Saving QER info to session: 2, {GateStatusUL:0 GateStatusDL:0 Qfi:1 MaxBitrateUL:0 MaxBitrateDL:0 StartUL:0 StartDL:0}
2023/11/25 20:40:26 INF Saving QER info to session: 1, {GateStatusUL:0 GateStatusDL:0 Qfi:0 MaxBitrateUL:1000000000 MaxBitrateDL:1000000000 StartUL:0 StartDL:0}
2023/11/25 20:40:26 Matched groups: []
2023/11/25 20:40:26 ERR SDFFilter err: SDF Filter: bad formatting. Should be compatible with regexp: ^permit out (icmp|ip|tcp|udp|\d+) from (any|[\d.]+|[\da-fA-F:]+)(?:/(\d+))?(?: (\d+|\d+-\d+))? to (assigned|[\d.]+|[\da-fA-F:]+)(?:/(\d+))?(?: (\d+|\d+-\d+))?$
2023/11/25 20:40:26 ERR error extracting PDR info: SDF Filter: bad formatting. Should be compatible with regexp: ^permit out (icmp|ip|tcp|udp|\d+) from (any|[\d.]+|[\da-fA-F:]+)(?:/(\d+))?(?: (\d+|\d+-\d+))? to (assigned|[\d.]+|[\da-fA-F:]+)(?:/(\d+))?(?: (\d+|\d+-\d+))?$
2023/11/25 20:40:26 Matched groups: [permit out ip from any to 10.60.0.0/16 ip any   10.60.0.0 16 ]
2023/11/25 20:40:26 INF Session Establishment Request from 192.168.14.141 accepted.
2023/11/25 20:40:26 INF Got Session Modification Request from: 192.168.14.141. 

2023/11/25 20:40:26 INF Finding association for 192.168.14.141
2023/11/25 20:40:26 INF Finding session 2
2023/11/25 20:40:26 INF 
Session Modification Request:
  UpdatePDR ID: 2 
    FAR ID: 2 
    Source Interface: 2 
    UE IPv4 Address: 10.60.0.1 
  UpdatePDR ID: 4 
    FAR ID: 4 
    Source Interface: 2 
    UE IPv4 Address: 10.60.0.1 
    SDF Filter: permit out ip from any to 10.60.0.0/16 
  UpdateFAR ID: 2 
    Apply Action: [2] 
    Update forwarding Parameters:
      Network Instance:internet 
      Outer Header Creation: &{OuterHeaderCreationDescription:256 TEID:1 IPv4Address:192.168.13.131 IPv6Address:<nil> PortNumber:0 CTag:0 STag:0} 
  UpdateFAR ID: 4 
    Apply Action: [2] 
    Update forwarding Parameters:
      Network Instance:internet 
      Outer Header Creation: &{OuterHeaderCreationDescription:256 TEID:1 IPv4Address:192.168.13.131 IPv6Address:<nil> PortNumber:0 CTag:0 STag:0} 

2023/11/25 20:40:26 INF Updating FAR info: 2, {FarInfo:{Action:2 OuterHeaderCreation:1 Teid:1 RemoteIP:2198710464 LocalIP:2534254784 TransportLevelMarking:0} GlobalId:1}
2023/11/25 20:40:26 INF Updating FAR info: 4, {FarInfo:{Action:2 OuterHeaderCreation:1 Teid:1 RemoteIP:2198710464 LocalIP:2534254784 TransportLevelMarking:0} GlobalId:3}
2023/11/25 20:40:26 INF Both F-TEID IE and UE IP Address IE are missing
2023/11/25 20:40:26 INF Both F-TEID IE and UE IP Address IE are missing

@s5uishida
Thank you for your comment
it's fixed

cmd/core/pdr.go Outdated Show resolved Hide resolved
@s5uishida
Copy link

Hi @arxxm

I have confirmed that this error no longer occurs.

Thank you very much!

@arxxm arxxm merged commit d3e78b8 into main Dec 4, 2023
6 checks passed
@pirog-spb pirog-spb deleted the 120-upf-ftup-fteid branch April 26, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants