feat: add runtime modification of log level #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirog-spb
reviewed
Oct 8, 2023
pirog-spb
reviewed
Oct 8, 2023
kade-ddnkv
changed the base branch from
393-add-log-levels-support-in-eupf
to
main
kade-ddnkv
changed the base branch from
main
to
393-add-log-levels-support-in-eupf
kade-ddnkv
force-pushed
the
437-add-runtime-modification-of-log-level
branch
from
59fbb3d to
d7c6dbb
Compare
kade-ddnkv
changed the base branch from
393-add-log-levels-support-in-eupf
to
main
kade-ddnkv
changed the base branch from
main
to
393-add-log-levels-support-in-eupf
|
There is a small issue: when config.yml is edited, function OnConfigChange in main.go is called two times. Seems that this problem is related to OS, which is firing an event multiple times. For instance, using |
kade-ddnkv
force-pushed
the
437-add-runtime-modification-of-log-level
branch
from
d7c6dbb to
5f2a053
Compare
kade-ddnkv
changed the base branch from
393-add-log-levels-support-in-eupf
to
main
pirog-spb
reviewed
Oct 10, 2023
pirog-spb
approved these changes
Oct 11, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.