Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(reports): add request & response bytes #901

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Conversation

Theodus
Copy link
Member

@Theodus Theodus commented Jul 24, 2024

This adds the following fields to the client query kafka message:

  • request_bytes: length of client query document in bytes
  • response_bytes length of client query response (JSON serialized) in bytes

@Theodus Theodus requested a review from LNSD July 24, 2024 12:24
Copy link
Contributor

@LNSD LNSD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@Theodus Theodus added DO NOT MERGE (needs decision) Awaiting decision from other groups and removed DO NOT MERGE (needs decision) Awaiting decision from other groups labels Jul 24, 2024
@Theodus Theodus merged commit 75d83fb into main Jul 24, 2024
3 checks passed
@Theodus Theodus deleted the theodus/reports branch July 24, 2024 16:50
@Theodus Theodus mentioned this pull request Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants