Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove extra configuration from network subgraph #880

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

Theodus
Copy link
Member

@Theodus Theodus commented Jul 15, 2024

This removes the overhead of configuring fields that are functionally unused (indexer address), and avoids situations where we may want to query trusted indexers at different deployments.

@Theodus Theodus requested a review from LNSD July 15, 2024 12:33
@Theodus Theodus mentioned this pull request Jul 15, 2024
Copy link
Contributor

@LNSD LNSD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, check my comment

graph-gateway/src/lib.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@LNSD LNSD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, check my comment

@Theodus Theodus requested a review from LNSD July 15, 2024 14:09
Copy link
Contributor

@LNSD LNSD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@Theodus Theodus merged commit caddd7c into main Jul 15, 2024
3 checks passed
@Theodus Theodus deleted the theodus/trusted-indexers branch July 15, 2024 14:11
Theodus added a commit that referenced this pull request Jul 15, 2024
# Release Notes
- fix: skip POI fetch until cache TTL expires (#860)
- feat: set gateway ID to signer address (#868)
- feat: add internal query client to network subgraph service (#856,
#880)
- feat: direct indexer query API (#867)
- fix: remove deprecated data science logs (#882)

# Configuration Changes
- `gateway_id` removed
- `network_subgraph` replaced by `trusted_indexers`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants