Skip to content

Commit

Permalink
pr comments
Browse files Browse the repository at this point in the history
  • Loading branch information
edewit committed Oct 16, 2023
1 parent ef203b7 commit 4c145bb
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions js/apps/account-ui/src/resources/Resources.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,14 @@ const Resources = () => {
unmountOnExit
>
<Tab
data-testId="myResources"
data-testid="myResources"
eventKey={0}
title={<TabTitleText>{t("myResources")}</TabTitleText>}
>
<ResourcesTab />
</Tab>
<Tab
data-testId="sharedWithMe"
data-testid="sharedWithMe"
eventKey={1}
title={<TabTitleText>{t("sharedWithMe")}</TabTitleText>}
>
Expand Down
4 changes: 2 additions & 2 deletions js/apps/account-ui/src/resources/ShareTheResource.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ export const ShareTheResource = ({
label={t("shareUser")}
type="string"
helperTextInvalid={errors.usernames?.message}
fielddata-testId="users"
fieldId="users"
isRequired
validated={
errors.usernames ? ValidatedOptions.error : ValidatedOptions.default
Expand Down Expand Up @@ -182,7 +182,7 @@ export const ShareTheResource = ({
)}
</FormGroup>
<FormProvider {...form}>
<FormGroup label="" fielddata-testId="permissions-selected">
<FormGroup label="" fieldId="permissions-selected">
<SelectControl
name="permissions"
variant="typeaheadmulti"
Expand Down

0 comments on commit 4c145bb

Please sign in to comment.