forked from keycloak/keycloak
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove transaction in InfinispanSingleUseObjectProvider#remove (keycl…
…oak#23708) Co-authored-by: mposolda <[email protected]>
- Loading branch information
1 parent
058d00f
commit 0853d48
Showing
3 changed files
with
125 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
115 changes: 115 additions & 0 deletions
115
...quillian/tests/base/src/test/java/org/keycloak/testsuite/model/SingleUseProviderTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,115 @@ | ||
| /* | ||
| * Copyright 2023 Red Hat, Inc. and/or its affiliates | ||
| * and other contributors as indicated by the @author tags. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| * | ||
| */ | ||
|
|
||
| package org.keycloak.testsuite.model; | ||
|
|
||
| import java.util.ArrayList; | ||
| import java.util.Collections; | ||
| import java.util.List; | ||
| import java.util.Map; | ||
| import java.util.concurrent.ConcurrentHashMap; | ||
| import java.util.concurrent.atomic.AtomicInteger; | ||
|
|
||
| import org.junit.Assert; | ||
| import org.junit.Test; | ||
| import org.keycloak.models.KeycloakSession; | ||
| import org.keycloak.models.SingleUseObjectProvider; | ||
| import org.keycloak.models.utils.KeycloakModelUtils; | ||
| import org.keycloak.representations.idm.RealmRepresentation; | ||
| import org.keycloak.testsuite.AbstractTestRealmKeycloakTest; | ||
| import org.keycloak.testsuite.arquillian.annotation.ModelTest; | ||
|
|
||
| /** | ||
| * @author <a href="mailto:[email protected]">Marek Posolda</a> | ||
| */ | ||
| public class SingleUseProviderTest extends AbstractTestRealmKeycloakTest { | ||
|
|
||
| private static final int ITEMS_COUNT = 100; | ||
| private static final int THREADS_COUNT = 20; | ||
| @Override | ||
| public void configureTestRealm(RealmRepresentation testRealm) { | ||
|
|
||
| } | ||
|
|
||
| @Test | ||
| @ModelTest | ||
| public void testConcurrentRemoveFromSingleUseCacheShouldFail(KeycloakSession session) throws Exception { | ||
| Map<Integer, Tracker> tracker = new ConcurrentHashMap<>(); | ||
|
|
||
| // Add some items to singleUse cache | ||
| KeycloakModelUtils.runJobInTransaction(session.getKeycloakSessionFactory(), (session1) -> { | ||
| for (int i = 0; i < ITEMS_COUNT; i++) { | ||
| Map<String, String> mapp = Collections.singletonMap("my-key-" + i, "my-value-" + i); | ||
| SingleUseObjectProvider singleUseProvider = session1.getProvider(SingleUseObjectProvider.class); | ||
| singleUseProvider.put("my-key-" + i, 1000, mapp); | ||
| tracker.put(i, new Tracker()); | ||
| } | ||
| }); | ||
|
|
||
| // Try to remove all items | ||
| Runnable runnable = () -> { | ||
|
|
||
| KeycloakModelUtils.runJobInTransaction(session.getKeycloakSessionFactory(), (session1) -> { | ||
| // Each thread trying to remove all items | ||
| for (int i = 0; i < ITEMS_COUNT ; i++) { | ||
| SingleUseObjectProvider singleUseProvider1 = session1.getProvider(SingleUseObjectProvider.class); | ||
| Map<String, String> data = singleUseProvider1.remove("my-key-" + i); | ||
| if (data != null) { | ||
| tracker.get(i).countSuccess.incrementAndGet(); | ||
| } else { | ||
| tracker.get(i).countFailures.incrementAndGet(); | ||
| } | ||
| } | ||
| }); | ||
| }; | ||
|
|
||
| // Try to remove all items concurrently | ||
| List<Thread> workers = new ArrayList<>(); | ||
| for (int j=0 ; j< THREADS_COUNT ; j++) { | ||
| Thread t = new Thread(runnable); | ||
| workers.add(t); | ||
| t.start(); | ||
| } | ||
|
|
||
| for (Thread t : workers) { | ||
| t.join(); | ||
| } | ||
|
|
||
| // Check countSuccess and countFailures. For each key, only single successful "remove" is allowed. Other threads should fail to remove the item and nothing should be found | ||
| for (Map.Entry<Integer, Tracker> entry : tracker.entrySet()) { | ||
| getLogger().info(entry.getKey() + ": " + entry.getValue()); | ||
| } | ||
|
|
||
| for (Map.Entry<Integer, Tracker> entry : tracker.entrySet()) { | ||
| Assert.assertEquals(1, entry.getValue().countSuccess.get()); | ||
| Assert.assertEquals(THREADS_COUNT - 1, entry.getValue().countFailures.get()); | ||
| } | ||
| } | ||
|
|
||
| private class Tracker { | ||
| AtomicInteger countSuccess = new AtomicInteger(0); | ||
| AtomicInteger countFailures = new AtomicInteger(0); | ||
|
|
||
| @Override | ||
| public String toString() { | ||
| return "success: " + countSuccess.get() + ", failures: " + countFailures.get(); | ||
| } | ||
|
|
||
| } | ||
| } |