Preserve aspect ratio during resizing when the user provides both width and height #52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
First of all, thanks for this simple yet powerful utility :-)
I implemented aspect ratio preservation during resizing when the user provides both width and height dimensions. This way, using
imgcat
with tools likefzf
is just wonderful, for example:fzf --preview='imgcat --width=$FZF_PREVIEW_COLUMNS --height=$(expr $FZF_PREVIEW_LINES \* 2) --half-height --depth=24bit {}'
I added the new CLI option
-P|--no-preserve-aspect-ratio
to disable it. I made it default totrue
because it doesn't make much sense to me to shrink an image before viewing it, but it's a breaking change. We may want to make it opt-in instead of opt-out if we care about backward compatibility.Finally, I ensured height to be greater than zero after resizing, just like it happens for width.