Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: Default to Birth Sex #157

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

jayckaiser
Copy link
Contributor

Hotfix: Default to Birth Sex

Description & motivation

By default, if studentEducationOrganizationAssociations.genderIdentity is not populated, no gender information makes it through to dim_student. In some Stadium implementations (like SCDE), genderIdentity is not accessible, but birthSex is.

This PR proposes defaulting to birthSex value if the genderIdentity field is empty.

PR Merge Priority:

  • Low
  • Medium
  • High

Changes to existing files:

  • bld_ef3__immutable_stu_demos.sql: Use a coalesce to prefer gender identity, then birth sex.

Tests and QC done:

This code has not been run in SCDE yet. I'd like to discuss whether this should be a default or a config option.

edu_wh PR Review Checklist:

Make sure the following have been completed before approving this PR:

  • Description of changes has been added to Unreleased section of CHANGELOG.md. Add under ## New Features for features, etc.
  • If a new configuration xwalk was added:
    • The code is written such that the xwalk is optional (preferred), and this behavior was tested, OR
    • The code is written such that the xwalk is required, and the required xwalk is added to edu_project_template, and this PR is flagged as breaking change (not for patch release)
    • A description for the new xwalk has been added to EDU documentation site here
  • If a new configuration variable was added:
    • The code is written such that the variable is optional (preferred), and this behavior was tested, OR
    • The code is written such that the variable is required, and a default value was added to edu_project_template, and this PR is flagged as breaking change (not for patch release)
    • A description for the new variable has been added to EDU documentation site here
  • Reviewer confirms the grain of all tables are unchanged, OR any changes are expected, communicated, and this PR is flagged as a breaking change (not for patch release)

@jayckaiser jayckaiser closed this Oct 21, 2024
@jayckaiser jayckaiser reopened this Oct 21, 2024
@jayckaiser jayckaiser marked this pull request as draft October 21, 2024 21:08
@jayckaiser jayckaiser requested a review from rlittle08 October 21, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant