-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial TPDM models #94
base: main
Are you sure you want to change the base?
Conversation
Copy pull request edanalytics#84 from original repository.
Base Credential model
Create initial TPDM base models
Revert "Create initial TPDM base models"
Revert "Base Credential model "
Create base/stage models (iteration)
macros/gen_skey.sql
Outdated
|
||
'k_survey_section': { | ||
'reference_name': 'certification_exam_reference', | ||
'col_list': ['surveyIdentifier', 'namespace', 'survey_section_title'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alphabetical
macros/gen_skey.sql
Outdated
'reference_name': 'performance_evaluation_reference', | ||
'col_list': ['educationOrganizationId', | ||
'performanceEvaluationTitle', | ||
'schoolYear'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be:
'col_list': ['educationOrganizationId',
'evaluationPeriodDescriptor',
'performanceEvaluationTitle',
'performanceEvaluationTypeDescriptor',
'schoolYear',
'termDescriptor'],
'performanceEvaluationTypeDescriptor', | ||
'personId', | ||
'sourceSystemDescriptor', | ||
'schoolYear', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alphabetical -- schoolYear before sourceSystem
'lower(source_system)', | ||
'lower(survey_id)', | ||
'lower(survey_response_id)'] | ||
) }} as k_credential, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this key definition is wrong
'lower(survey_id)', | ||
'lower(survey_response_id)'] | ||
) }} as k_credential, | ||
{{ gen_skey('k_student_academic_record')}}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this line -- this is a list of academic records, so you can't run gen_skey on it directly
'api_year', | ||
'ed_org_id', | ||
'lower(performance_evaluation_title)', | ||
'school_year' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'tenant_code',
'api_year',
'ed_org_id',
'lower(evaluation_period)',
'lower(performance_evaluation_title)',
'lower(performance_evaluation_type)',
'school_year',
'lower(academic_term)'
'lower(evaluation_element_title)', | ||
'lower(evaluation_objective_title)', | ||
'lower(evaluation_period)', | ||
'lower(valuation_title)', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
evaluation_title
'lower(performance_evaluation_title)', | ||
'lower(performance_evaluation_type)', | ||
'school_year', | ||
'rubric_rating', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alphabetical: rubric before school
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is ed-fi namespaced, so it and its stage should be moved to the other folder and named appropriately
v:beginDate::date as begin_date, | ||
v:studentReference:studentUniqueId::string as student_unique_id, | ||
-- non-identity components | ||
v:beginDate::date as begin_date, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
duplicate column
Resolve PR comments
Debug tpdm models
fix: programAssignmentDescriptor in staff_school_associations
Feature/change tpdm enable flag
Fix bug with null academic subjects data in staff school associations
All additional ed-fi models with data currently seen. Most of these new models come from TPDM.