Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial TPDM models #94

Open
wants to merge 94 commits into
base: main
Choose a base branch
from
Open

Initial TPDM models #94

wants to merge 94 commits into from

Conversation

holdorph
Copy link

@holdorph holdorph commented Jul 18, 2024

All additional ed-fi models with data currently seen. Most of these new models come from TPDM.

maxalmazov and others added 30 commits July 3, 2024 18:18
Copy pull request edanalytics#84 from original repository.
@holdorph holdorph requested a review from ejoranlienea August 1, 2024 17:52

'k_survey_section': {
'reference_name': 'certification_exam_reference',
'col_list': ['surveyIdentifier', 'namespace', 'survey_section_title'],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alphabetical

'reference_name': 'performance_evaluation_reference',
'col_list': ['educationOrganizationId',
'performanceEvaluationTitle',
'schoolYear'],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be:

'col_list': ['educationOrganizationId', 
                         'evaluationPeriodDescriptor',
                         'performanceEvaluationTitle', 
                         'performanceEvaluationTypeDescriptor',
                         'schoolYear',
                         'termDescriptor'],

'performanceEvaluationTypeDescriptor',
'personId',
'sourceSystemDescriptor',
'schoolYear',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alphabetical -- schoolYear before sourceSystem

'lower(source_system)',
'lower(survey_id)',
'lower(survey_response_id)']
) }} as k_credential,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this key definition is wrong

'lower(survey_id)',
'lower(survey_response_id)']
) }} as k_credential,
{{ gen_skey('k_student_academic_record')}},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this line -- this is a list of academic records, so you can't run gen_skey on it directly

'api_year',
'ed_org_id',
'lower(performance_evaluation_title)',
'school_year'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'tenant_code',
'api_year',
'ed_org_id',
'lower(evaluation_period)',
'lower(performance_evaluation_title)',
'lower(performance_evaluation_type)',
'school_year',
'lower(academic_term)'

'lower(evaluation_element_title)',
'lower(evaluation_objective_title)',
'lower(evaluation_period)',
'lower(valuation_title)',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

evaluation_title

'lower(performance_evaluation_title)',
'lower(performance_evaluation_type)',
'school_year',
'rubric_rating',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alphabetical: rubric before school

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is ed-fi namespaced, so it and its stage should be moved to the other folder and named appropriately

v:beginDate::date as begin_date,
v:studentReference:studentUniqueId::string as student_unique_id,
-- non-identity components
v:beginDate::date as begin_date,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicate column

@holdorph holdorph requested a review from ejoranlienea August 7, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants