Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error handling for PaDEL-Descriptor not returning any calculated values #13

Merged
merged 3 commits into from
Jun 16, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion padelpy/__init__.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
from padelpy.wrapper import padeldescriptor
from padelpy.functions import from_mdl, from_smiles
__version__ = '0.1.6'
__version__ = '0.1.7'
17 changes: 12 additions & 5 deletions padelpy/functions.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# -*- coding: utf-8 -*-
#
# padelpy/functions.py
# v.0.1.6
# v.0.1.7
# Developed in 2019 by Travis Kessler <[email protected]>
#
# Contains various functions commonly used with PaDEL-Descriptor
Expand All @@ -20,8 +20,8 @@
from padelpy import padeldescriptor


def from_smiles(smiles: str, output_csv: str=None, descriptors: bool=True,
fingerprints: bool=False, timeout: int=12) -> OrderedDict:
def from_smiles(smiles: str, output_csv: str = None, descriptors: bool = True,
fingerprints: bool = False, timeout: int = 12) -> OrderedDict:
''' from_smiles: converts SMILES string to QSPR descriptors/fingerprints

Args:
Expand Down Expand Up @@ -78,12 +78,16 @@ def from_smiles(smiles: str, output_csv: str=None, descriptors: bool=True,
if not save_csv:
remove(output_csv)

if len(rows) == 0:
raise RuntimeError('PaDEL-Descriptor returned no calculated values.' +
' Ensure the input structure is correct.')

del rows[0]['Name']
return rows[0]


def from_mdl(mdl_file: str, output_csv: str=None, descriptors: bool=True,
fingerprints: bool=False, timeout: int=12) -> list:
def from_mdl(mdl_file: str, output_csv: str = None, descriptors: bool = True,
fingerprints: bool = False, timeout: int = 12) -> list:
''' from_mdl: converts MDL file into QSPR descriptors/fingerprints;
multiple molecules may be represented in the MDL file

Expand Down Expand Up @@ -141,6 +145,9 @@ def from_mdl(mdl_file: str, output_csv: str=None, descriptors: bool=True,
desc_file.close()
if not save_csv:
remove(output_csv)
if len(rows) == 0:
raise RuntimeError('PaDEL-Descriptor returned no calculated values.' +
' Ensure the input structure is correct.')
for row in rows:
del row['Name']
return rows
26 changes: 14 additions & 12 deletions padelpy/wrapper.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# -*- coding: utf-8 -*-
#
# padelpy/wrapper.py
# v.0.1.6
# v.0.1.7
# Developed in 2019 by Travis Kessler <[email protected]>
#
# Contains the `padeldescriptor` function, a wrapper for PaDEL-Descriptor
Expand Down Expand Up @@ -45,17 +45,19 @@ def _popen_timeout(command: str, timeout: int) -> tuple:
return p.communicate()


def padeldescriptor(maxruntime: int=-1, waitingjobs: int=-1, threads: int=-1,
d_2d: bool=False, d_3d: bool=False, config: str=None,
convert3d: bool=False, descriptortypes: str=None,
detectaromaticity: bool=False, mol_dir: str=None,
d_file: str=None, fingerprints: bool=False,
log: bool=False, maxcpdperfile: int=0,
removesalt: bool=False, retain3d: bool=False,
retainorder: bool=False, standardizenitro: bool=False,
standardizetautomers: bool=False, tautomerlist: str=None,
usefilenameasmolname: bool=False,
sp_timeout: int=None) -> None:
def padeldescriptor(maxruntime: int = -1, waitingjobs: int = -1,
threads: int = -1, d_2d: bool = False, d_3d: bool = False,
config: str = None, convert3d: bool = False,
descriptortypes: str = None,
detectaromaticity: bool = False, mol_dir: str = None,
d_file: str = None, fingerprints: bool = False,
log: bool = False, maxcpdperfile: int = 0,
removesalt: bool = False, retain3d: bool = False,
retainorder: bool = False, standardizenitro: bool = False,
standardizetautomers: bool = False,
tautomerlist: str = None,
usefilenameasmolname: bool = False,
sp_timeout: int = None) -> None:
''' padeldescriptor: complete wrapper for PaDEL-Descriptor descriptor/
fingerprint generation software

Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

setup(
name='padelpy',
version='0.1.6',
version='0.1.7',
description='A Python wrapper for PaDEL-Descriptor',
url='https://github.com/ecrl/padelpy',
author='Travis Kessler',
Expand Down