-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update composer.json for SF7 #98
Conversation
dependencies updates for symfony 7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
Do you think making it compatible with Symfony 6 and 7 would be a good idea ?
Hi, previous version was already compatible with Symfony 6 so why not following up with 7 ? |
Hello, Why did you close the PR ? FYI, I received a request for making it compatible with SF7 yesterday, I gave more information in the issue itself at #97 |
Hello, No testing was done for both SF 6 & 7 and the code had to be changed. Therefore I wanted to make sure this would work. But if you want to work on it be my guest because I am struggling to test it locally atm. |
I'm confused. If you open a PR against this project, I guess that's because you want some stuff to be updated in it, right? |
Yes but your comment was right, my code was not considering the bundle to work for both symfony 6 and 7 at the same time. It needed some changes |
OK OK ! Yeah if you could reopen your PR and update to |
6+7 dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also use ^6.1
in place of ^6.0
?
6.0 to 6.1
Nice! Thank you very much. @Punt13140 Do you mind testing that branch and see if it works on your side? In case of a yes, I'll cut a new release immediately. @StudioAH No worries about the broken tests, I'll take care of it myself. |
I quickly tried to install the bundle in a new Symfony 7 project, and it doesn't work out of the box. I have dependency problems with
Trying to change
We have another dependency problem with
which depends on However, it seems that the latter now follows Symfony tags since 6.4...
|
Merging this PR and continue the work in #100 ! |
Thank you both !!! |
dependencies updates for symfony 7
This PR
Follows #. Related to #97. Fixes #.