Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve coverage #14

Merged
merged 1 commit into from
Jul 10, 2020
Merged

improve coverage #14

merged 1 commit into from
Jul 10, 2020

Conversation

IonBazan
Copy link
Contributor

@IonBazan IonBazan commented Jul 10, 2020 •
edited
Loading

This PR

  • Filters out src/Resources directory from coverage report (recent yaml/xml -> php configuration changes decreased coverage)
  • Adds return type hints where possible
  • Adds more tests for controllers

Coverage (lines): 49% -> 86%
MSI: 72% -> 80%

@drupol
Copy link
Member

drupol commented Jul 10, 2020

This is great !!! It was on my todo list :-)

Thanks !!!

@drupol drupol merged commit a6aaea6 into ecphp:master Jul 10, 2020
@IonBazan IonBazan deleted the coverage branch July 10, 2020 11:50
@IonBazan
Copy link
Contributor Author

Glad I could help. Great lib 😉

@drupol
Copy link
Member

drupol commented Jul 10, 2020

Glad it help you :-)

drupol pushed a commit that referenced this pull request Jul 23, 2020
@IonBazan @drupol
Improve coverage (#14)
8903595
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IonBazan @drupol