dropping behat tests from PdoEventSourcing module #143
Conversation
unixslayer
force-pushed
the
main
branch
3 times, most recently
from
9c2d862
to
930548e
Compare
unixslayer
changed the title
unixslayer
force-pushed
the
main
branch
6 times, most recently
from
50eb8b5
to
b5a6420
Compare
unixslayer
changed the title
unixslayer
force-pushed
the
main
branch
3 times, most recently
from
0ee4d38
to
c13f145
Compare
dropping behat tests from PdoEventSourcing module and rewriting them using Ecotone Test Support using pcov for coverage report
There was a problem hiding this comment.
Amazing refactor. You've put a lot of heart into this, thanks :)
It's worth to give a context to this PR:
Ecotone Lite tests based on phpunit are much more easy to maintain than behat ones.
The behat tests were introduced before Ecotone Lite testing support were introduced and all new tests will be written in phpunit instead.
| { | ||
| // fixme Calling ProjectionManager to delete the projection throws `Header with name ecotone.eventSourcing.manager.deleteEmittedEvents does not exists` exception | ||
| //$this->getGateway(ProjectionManager::class)->deleteProjection($projectionName); | ||
| $this->configuredMessagingSystem->runConsoleCommand('ecotone:es:delete-projection', ['name' => $projectionName]); |
There was a problem hiding this comment.
Yep, if you take a look on the defined interface it requires deleteEmittedEvents, this would be needed to add as optional to make it work
| ->withExtensionObjects([ | ||
| EventSourcingConfiguration::createWithDefaults(), | ||
| ]), | ||
| pathToRootCatalog: __DIR__ . '/../../', |
There was a problem hiding this comment.
Ecotone Lite have problem resolving this automatically, because for split testing it use symlinks. And it count the root catalog from symlink instead of real vendor catalog. Maybe you have idea how to solve this?
| 'Test\Ecotone\EventSourcing\Fixture\ProjectionFromCategoryUsingAggregatePerStream', | ||
| 'Test\Ecotone\EventSourcing\Fixture\Basket', | ||
| 'Test\Ecotone\EventSourcing\Fixture\Ticket', | ||
| ]) |
There was a problem hiding this comment.
I love how the namespaces help reuse scenarios
| self::assertFalse($connection->createSchemaManager()->tablesExist('in_progress_tickets')); | ||
| } | ||
|
|
||
| public function test_building_multiple_polling_projection(): void |
There was a problem hiding this comment.
Thanks for adjusting this and being so precise about what we are testing. This will helpful for the maintainers in case of breaking the test
There was a problem hiding this comment.
About that maintainers thing ... I noticed there is only one at the moment ;)
There was a problem hiding this comment.
I think we can consider this one resolve now :)
There was a problem hiding this comment.
About that maintainers thing ... I noticed there is only one at the moment ;)
Haha 😉
No description provided.