Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConsumptionSaving PEP8 conversions #959

Merged
merged 6 commits into from
Feb 28, 2021

Conversation

sbenthall
Copy link
Contributor

@sbenthall sbenthall commented Feb 23, 2021

Building on #953, this converts method names in ConsumptionSaving to PEP 8 style.

When there is the name of a mathematical object, this is left in its original style.

  • Tests for new functionality/models or Tests to reproduce the bug-fix in code.
  • Updated documentation of features that add new functionality.
  • Update CHANGELOG.md with major/minor changes.

@sbenthall sbenthall added this to the 1.0.0 milestone Feb 23, 2021
@@ -236,7 +236,7 @@ \subsection{Idiosyncratic and Aggregate Shocks to Income}

The objects $\textbf{R}(\cdot)$ and $\textbf{W}(\cdot)$, are functions of the (effective) capital-to-labor ratio that yield the (net) interest factor and wage rate respectively. As noted above, these are determined by the aggregate production function and the degree of capital depreciation. The $\texttt{k}(\cdot)$ function represents the agent's beliefs about the evolution of the capital-to-labor ratio $k_t$. As with idiosyncratic shocks, there is an aggregate shock process $(F_{\Theta},F_{\Psi})$.

The one period problem of this model is solved by the function \texttt{solveConsAggShock}, the default value of \texttt{solveOnePeriod} for \texttt{AggShockConsumerType}. The attributes required to specify an instance of this class are listed in the concordance below.
The one period problem of this model is solved by the function \texttt{solveConsAggShock}, the default value of \texttt{solve_one_period} for \texttt{AggShockConsumerType}. The attributes required to specify an instance of this class are listed in the concordance below.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not change the legacy .tex files

remove it entirely!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

double check to make sure it's not being used before removing it

@sbenthall
Copy link
Contributor Author

@llorracc coordinate with @sbenthall and then merge

@codecov-io
Copy link

Codecov Report

Merging #959 (c285d99) into master (449f40f) will not change coverage.
The diff coverage is 96.62%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #959   +/-   ##
=======================================
  Coverage   71.84%   71.84%           
=======================================
  Files          62       62           
  Lines        9204     9204           
=======================================
  Hits         6613     6613           
  Misses       2591     2591           
Impacted Files Coverage Δ
HARK/ConsumptionSaving/ConsMedModel.py 74.27% <90.90%> (ø)
HARK/ConsumptionSaving/ConsPrefShockModel.py 80.30% <91.66%> (ø)
HARK/ConsumptionSaving/ConsGenIncProcessModel.py 89.21% <94.59%> (ø)
HARK/ConsumptionSaving/ConsAggShockModel.py 89.70% <95.16%> (ø)
HARK/ConsumptionSaving/ConsMarkovModel.py 86.20% <95.23%> (ø)
HARK/ConsumptionSaving/ConsIndShockModel.py 86.61% <100.00%> (ø)
HARK/ConsumptionSaving/ConsIndShockModelFast.py 51.05% <100.00%> (ø)
HARK/ConsumptionSaving/ConsLaborModel.py 82.90% <100.00%> (ø)
HARK/ConsumptionSaving/ConsPortfolioModel.py 67.27% <100.00%> (ø)
HARK/ConsumptionSaving/ConsRepAgentModel.py 100.00% <100.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 449f40f...c285d99. Read the comment docs.

@sbenthall sbenthall merged commit 05ef324 into econ-ark:master Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants