-
-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add csv's to MANIFEST.in #957
Conversation
Codecov Report
@@ Coverage Diff @@
## master #957 +/- ##
=======================================
Coverage 71.43% 71.43%
=======================================
Files 62 62
Lines 9145 9145
=======================================
Hits 6533 6533
Misses 2612 2612 Continue to review full report at Codecov.
|
@MridulS, this looks like one for you. |
@Mv77 yup, need to put in these data files to make sure its packaged properly :) |
@Mv77 Do you think it's possible to get a more flat structure in the datasets directory? Like moving all the csv files to the |
@Mv77 just wanted to bump this up. |
* Add csv's to manifest * Update CHANGELOG.md * Update MANIFEST.in
I tried to get feedback on the location and format of the tools in my PR's (See #921, #922) and calls with @llorracc . I proposed a format for datasets in which each had its folder with:
@llorracc and @sbenthall seemed to like it. Flattening the dir structure is possible and would be advantageous in some dimensions, but it would go against concerns and principles that were brought up when I was creating the tools like:
I am not sure where the balance of those conveniences and concerns lands. |
Thanks for the links, yeah I agree its a tricky balance between future proofing our code and conveniences. Something like |
My recent calibration tools added a couple datasets in csv format to the toolbox.
However, I had no idea these needed to be in the
MANIFEST.in
file to get collected when one installs HARK.I noticed the issue while messing around with some conda environments for a cluster, and wondering why my tools were not working after installing HARK.
This tiny pr fixes the issue. It is my first time working with
MANIFEST.in
, could someone review?