Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

using assignParameters as parameter set method; robust support and use across library. #947

Merged
merged 10 commits into from
Feb 18, 2021
Merged

using assignParameters as parameter set method; robust support and use across library. #947

merged 10 commits into from
Feb 18, 2021

Conversation

sbenthall
Copy link
Contributor

@sbenthall sbenthall commented Feb 10, 2021 •
edited
Loading

Address #679 by making more robust use of assignParameters and removing the __call__ alternative method of setting parameters.

Adds a get_parameter method.

Will need to change assignParameters to assign_parameters as part of #907

  • Tests for new functionality/models or Tests to reproduce the bug-fix in code.
  • Updated documentation of features that add new functionality.
  • Update CHANGELOG.md with major/minor changes.

@sbenthall sbenthall changed the title I679 using assignParameters as parameter set method; robust support and use across library. Feb 10, 2021
@sbenthall sbenthall requested a review from MridulS February 11, 2021 17:49
@MridulS MridulS merged commit 6d79519 into econ-ark:master Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MridulS MridulS MridulS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbenthall @MridulS