rewrite calcExpectation to use numpy methods, see #625 #897
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rewrites
calcExpectation
to usenumpy.apply_along_axis
.It is a much more succinct implementation.
This rewritten version does not compute the tensor product in cases of multiple 1D value inputs.
I have argued in #625 that this should be handled by a different method outside of the
calcExpectation
function.What this PR lacks in terms of functionality compared to the first implementation, it makes up for in automated tests.
This PR includes tests, including for multivariate distributions with both array and constant non-stochastic values.