Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add liquidity constraint to perfect foresight model examples #795

Merged
merged 2 commits into from
Aug 13, 2020

Conversation

alanlujan91
Copy link
Member

@alanlujan91 alanlujan91 commented Aug 12, 2020

Please ensure your pull request adheres to the following guidelines:

  • [N/A] Tests for new functionality/models or Tests to reproduce the bug-fix in code.
  • [N/A] Updated documentation of features that add new functionality.
  • [N/A] Update CHANGELOG.md with major/minor changes.

The notebooks mentioned in econ-ark/DemARK#35 were moved from DEMARK to HARK/examples.

This PR updates model notebooks to account for the existence of BoroCnstArt in the perfect foresight model. It should only be merged after this feature has been included in a public release of HARK, otherwise the notebook will break; likewise, it should be merged immediately otherwise the notebook will break.

The changes are migrated on this PR.

Additional changes made:

  • time.clock has been deprecated since python 3.3 and removed in 3.8; also it's not used anywhere in the code, so i have removed it
  • I've changed hist_x to history["x"] where needed
  • changed unpackcFunc() to unpack("cFunc") where needed

@mnwhite mnwhite changed the title Add liquidity constraint to perfect foresight model Add liquidity constraint to perfect foresight model examples Aug 12, 2020
@llorracc llorracc merged commit 66a6643 into econ-ark:master Aug 13, 2020
@alanlujan91 alanlujan91 deleted the AddLiqConstrToPF branch September 10, 2020 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants