Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal with cases when the agent wants to short #749

Merged
merged 2 commits into from
Jul 2, 2020

Conversation

Mv77
Copy link
Contributor

@Mv77 Mv77 commented Jul 2, 2020

This implements the solution proposed by @mnwhite in #741 for dealing with cases where the agent wants to hold less than a 0% share of the risky asset.

I did some testing and it seems to be well behaved. The approach assumes that as long as the FOC at s=0 is negative, the agent wants to hold less than 0. I guess it will break if one considers non-concavities in the value function?

I got rid of the try-except block as @mnwhite suggested.

@llorracc
Copy link
Collaborator

llorracc commented Jul 2, 2020

I guess it will break if one considers non-concavities in the value function?

Yes; but anything will break under those circs. We may need to handle this in the future (esp when trying to have a discrete-continuous problem jointly with the portfolio problem) but that's a problem for another day.

@mnwhite
Copy link
Contributor

mnwhite commented Jul 2, 2020 via email

@Mv77
Copy link
Contributor Author

Mv77 commented Jul 2, 2020

I guess it will break if one considers non-concavities in the value function?

Yes; but anything will break under those circs. We may need to handle this in the future (esp when trying to have a discrete-continuous problem jointly with the portfolio problem) but that's a problem for another day.

Yes, exactly. Since I know we will eventually have to deal with this, I just want to keep a mental list of where things might break.

@mnwhite
Copy link
Contributor

mnwhite commented Jul 2, 2020

Yes, this is exactly correct. And I guess I had already handled the 100% constraint, now labeled as top_constraint; that might be why I thought I dealt with the 0% constraint as well. Nice work.

@mnwhite mnwhite merged commit 0bd0595 into econ-ark:master Jul 2, 2020
@Mv77 Mv77 deleted the PortfolioWithBadAsset branch July 2, 2020 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants