change _hist constructions to history namespace #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess this doesn't break the AggShockModel |
|
Interesting. I will try to look at this and merge tomorrow.
…On Wed, May 6, 2020 at 8:40 PM Sebastian Benthall ***@***.***> wrote:
I guess this doesn't break the AggShockModel
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#674 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADKRAFI2LWBA2SCMJLAYXUTRQH7ONANCNFSM4M2TZU3Q>
.
|
|
If this change looks good, then the next very low hanging fruit is to replace the setattr and getattrs used for the "now" values to also be replaced with a dictionary, maybe called |
|
I'm ok with this, but not sure about the name "state". Some of the "Now"
variables are states, some are controls, and some are something else
entirely (like the MPC, the derivative of a control with respect to a
state).
…On Thu, May 7, 2020 at 9:29 AM Sebastian Benthall ***@***.***> wrote:
If this change looks good, then the next very low hanging fruit is to
replace the setattr and getattrs used for the "now" values to also be
replaced with a dictionary, maybe called state.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#674 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADKRAFMF6GAZJY4MY47ABX3RQKZT7ANCNFSM4M2TZU3Q>
.
|
|
Hmmm. Ok, I definitely like the idea of putting them in separate namespaces. I'll work that out in a different PR, after this one is merged. |
|
Feature passes the review, need to fix it in examples. |
|
Try to make examples work with this. CDC also wants DEMARKS to work. |
|
I can't make DemARKs work with code that is not yet committed to HARK. |
|
Yeah, let's get the examples functional and then merge this.
…On Thu, May 21, 2020 at 10:19 AM Sebastian Benthall < ***@***.***> wrote:
I can't make DemARKs work with code that is not yet committed to HARK.
This is an order of operations issue.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#674 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADKRAFNWC3O2IKIWUBVOBLTRSUZ55ANCNFSM4M2TZU3Q>
.
|
|
Latest commit should fix examples |
|
Excellent.
…On Thu, May 21, 2020 at 8:49 PM Sebastian Benthall ***@***.***> wrote:
Latest commit should fix examples
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#674 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADKRAFJ4T7S6G4E2P2IXD5LRSXD2RANCNFSM4M2TZU3Q>
.
|
|
...I really thought I merged this right after the examples were working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #495 ...
In the current functionality, during a simulation the state history is stored on the model object in fields named X_hist.
These state variables are being accessed with
getattrand set withsetattr.This PR replaces storage on the object with storage in a dictionary.
So, X_hist is replaced with
history[X].There are several reasons for this change:
Note: the PR currently passes tests, but it looks like it may break the functionality of ConsAggShockModel. New tests for ConsAggShock are introduced in #654. Please merge that PR first.