Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding ConsumptionSaving to the docs #469

Merged
merged 10 commits into from
Feb 1, 2020
Merged

Conversation

sbenthall
Copy link
Contributor

This PR addresses #468

@sbenthall sbenthall requested a review from MridulS January 8, 2020 03:44
Copy link
Member

@MridulS MridulS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have just HARK.ConsumptionSaving on the home page instead of all the models?

@llorracc
Copy link
Collaborator

llorracc commented Jan 8, 2020 via email

@sbenthall
Copy link
Contributor Author

I'm not sure how to do this cleanly.
I can try to figure it out. Do you know how, @MridulS ?

@sbenthall
Copy link
Contributor Author

@sbenthall
Copy link
Contributor Author

I've played around with this some.
Most recent commit reflects my best sense of how to do this.

The autosummary feature of Sphinx takes a lot of control over the creation of the docs.
It looks like it winds up creating javascript that overwrites the markup of the api.rst file, which makes it difficult to configure around.

It looks like most other projects use a more hands-on approach to configuring their documentation.

What about splitting up the docs into 'Tools' and 'Models'?

In the current PR, no individual classes are listed on the documentation home page.

@sbenthall
Copy link
Contributor Author

As of the most recent commit:

  • All the tools are listed individually in the TOC sidebar, which links to their own pages with module definition.
  • HARK.ConsumptionSaving appears in the sidebar; its page documents all of its submodules.

Requesting review.

@sbenthall
Copy link
Contributor Author

This new commit gets things to how we discussed in the last meeting:

  • the HARK.ConsumptionSaving page now has a list of its submodules
  • each of the submodules has its own page, with expanded documentation
  • those pages appear in the side-bar/TOC in a sensible way.

2782380

Requesting review from @MridulS

@sbenthall sbenthall mentioned this pull request Jan 20, 2020
@sbenthall
Copy link
Contributor Author

You can see how this works on my fork's RTD's now:
https://hark-sb.readthedocs.io/en/i468/api-consumptionsaving.html

@sbenthall
Copy link
Contributor Author

It looks like there's something wrong with the status checks after the recent merge from master.

The GitHub actions tests have all passed.
But it looks like the Travis CI build has hung for 11 hours.

@MridulS
Copy link
Member

MridulS commented Jan 31, 2020

all good now, Travis just needed a little bit of nudge to rebuild it.

@sbenthall
Copy link
Contributor Author

look ok to merge?

@MridulS
Copy link
Member

MridulS commented Feb 1, 2020

+1

@MridulS MridulS merged commit c22ce40 into econ-ark:master Feb 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants