Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Journey 1; targeting PhD students - new version to compile all notebooks. #380

Merged
merged 14 commits into from
Mar 5, 2020

Conversation

janrosa1
Copy link
Contributor

@janrosa1 janrosa1 commented Aug 6, 2019

Additionally, I changed a notebook on the individual consumers, to make it more consistent with quick start (only a version in the documentation directory)

@sbenthall
Copy link
Contributor

@janrosa1 this is great work!

I've had the make a few edits as part of the merge.
You should be able to get them into this PR #380 by merging my changes into your master branch:
janrosa1#4

@janrosa1
Copy link
Contributor Author

janrosa1 commented Feb 14, 2020 via email

@sbenthall
Copy link
Contributor

@janrosa1 Would you permit me to make the changes necessary to complete this merge myself?

@sbenthall
Copy link
Contributor

@llorracc Can you please check with @janrosa1 about this?

@janrosa1
Copy link
Contributor Author

janrosa1 commented Mar 5, 2020 via email

Copy link
Contributor Author

@janrosa1 janrosa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for a delay in approval

@janrosa1
Copy link
Contributor Author

janrosa1 commented Mar 5, 2020 via email

@sbenthall
Copy link
Contributor

OK, no problem @janrosa1 . Just wanted to respect your contributions :) Thank you for your good work!

@janrosa1
Copy link
Contributor Author

janrosa1 commented Mar 5, 2020 via email

@sbenthall sbenthall merged commit adc712a into econ-ark:master Mar 5, 2020
@MridulS MridulS mentioned this pull request Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants