-
-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Journey 1; targeting PhD students - new version to compile all notebooks. #380
Conversation
updating hark
updating
update hark
…oduction, small corrections
…oduction, small corrections
@janrosa1 this is great work! I've had the make a few edits as part of the merge. |
Thanks, will check it! Sorry, for late answer.
czw., 6 lut 2020 o 11:44 Sebastian Benthall <[email protected]>
napisał(a):
… @janrosa1 <https://github.com/janrosa1> this is great work!
I've had the make a few edits as part of the merge.
You should be able to get them into this PR #380
<#380> by merging my changes into
your master branch:
janrosa1#4 <janrosa1#4>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#380?email_source=notifications&email_token=AENCRHSKFLHSZWPPGB5RJGLRBRSAXA5CNFSM4IJWZ46KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELAQX4A#issuecomment-583076848>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AENCRHU5VSS6RHFX2UW5L33RBRSAXANCNFSM4IJWZ46A>
.
|
@janrosa1 Would you permit me to make the changes necessary to complete this merge myself? |
I am still new to big group project at Github, thought that I do need to
authorize your pull request, as you are a contributor to the main project.
I am very sorry about this, I hope you did not lose too much time.
Best,
Jan
czw., 5 mar 2020, 09:08 użytkownik Sebastian Benthall <
[email protected]> napisał:
… @llorracc <https://github.com/llorracc> Can you please check with
@janrosa1 <https://github.com/janrosa1> about this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#380?email_source=notifications&email_token=AENCRHVZ3LP7XMVUDRYMFVTRF7MCFA5CNFSM4IJWZ46KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEN6DB3Q#issuecomment-595341550>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AENCRHUMXA4C53KXVX63E7LRF7MCFANCNFSM4IJWZ46A>
.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for a delay in approval
I submitted a review, please let me know if it is what I was supposed to
do.
Again, I am very sorry for this.
Best,Jan
czw., 5 mar 2020 o 09:38 Jan Rosa <[email protected]> napisał(a):
… I am still new to big group project at Github, thought that I do need to
authorize your pull request, as you are a contributor to the main project.
I am very sorry about this, I hope you did not lose too much time.
Best,
Jan
czw., 5 mar 2020, 09:08 użytkownik Sebastian Benthall <
***@***.***> napisał:
> @llorracc <https://github.com/llorracc> Can you please check with
> @janrosa1 <https://github.com/janrosa1> about this?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#380?email_source=notifications&email_token=AENCRHVZ3LP7XMVUDRYMFVTRF7MCFA5CNFSM4IJWZ46KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEN6DB3Q#issuecomment-595341550>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AENCRHUMXA4C53KXVX63E7LRF7MCFANCNFSM4IJWZ46A>
> .
>
|
OK, no problem @janrosa1 . Just wanted to respect your contributions :) Thank you for your good work! |
Thank you! I looked at the changes before (the not technical ones) and do
not have any comments, but should let you know about it.
czw., 5 mar 2020 o 09:50 Sebastian Benthall <[email protected]>
napisał(a):
… OK, no problem @janrosa1 <https://github.com/janrosa1> . Just wanted to
respect your contributions :) Thank you for your good work!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#380?email_source=notifications&email_token=AENCRHV4BNUIIDGTHRJ7O7TRF7Q7TA5CNFSM4IJWZ46KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEN6HYKQ#issuecomment-595360810>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AENCRHRJ4PE63QWEGDDE3Z3RF7Q7TANCNFSM4IJWZ46A>
.
|
Additionally, I changed a notebook on the individual consumers, to make it more consistent with quick start (only a version in the documentation directory)