Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comment out parallel SGU_solver, works for py3 #341

Merged
merged 2 commits into from
Jul 13, 2019

Conversation

MridulS
Copy link
Member

@MridulS MridulS commented Jul 6, 2019

Fixes #198

@llorracc
Copy link
Collaborator

llorracc commented Jul 6, 2019

@MridulS, looks like you deleted the version of the code that only worked in serial. Could you restore it, but in comments? In case for some reason (like a misconfigured machine) some people want to revert to it.

@MridulS
Copy link
Member Author

MridulS commented Jul 6, 2019

I'll add back the sequential code after completing #342 so there aren't any merge conflicts.

@llorracc
Copy link
Collaborator

llorracc commented Jul 6, 2019

Still looks to me like in your PR the old code has been deleted instead of commented out ...

@MridulS
Copy link
Member Author

MridulS commented Jul 11, 2019

@llorracc added it back.

@llorracc
Copy link
Collaborator

Travis has been working on this for way too long -- I want to merge but our rules won't let me until Travis is happy ...

@MridulS
Copy link
Member Author

MridulS commented Jul 12, 2019

fixed the conflict, travis is happy now

@llorracc
Copy link
Collaborator

Thanks.

PS. I just saw Travis -- the actual PERSON -- get chased off the stage because he was exceeding his allotted 5 mins for a "lighting talk" at SciPy! Just like his tool, I guess, sometimes he needs prodding ...

@llorracc llorracc merged commit 1e0bf86 into econ-ark:master Jul 13, 2019
@shaunagm
Copy link
Contributor

Pretty sure that Travis and the tool Travis are unrelated, but I support sending sad emails to scipy Travis whenever the tool doesn't work for us...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Multiprocessing to BayerLuettike code
3 participants