Throw an Exception if model has not been solved prior to simulate'ing #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test simulate behavior when solve has not been called. Remove conflicts for real. Use assertRaises.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, I'm just PRing some minor things I'm finding on my way to matching a portfolio share. I've actually thought about this before (last fall!) but you quickly forget these things/learn to live with them.
Essentially, before this PR, if you tried to
simulate(), but you hadn'tsolve()ed, you would just get a message stating thatI'm not sure that all new users, and maybe new python users, would immediately know why this is. We probably know what went wrong though! They didn't
solve.Added a simple test to verify that this is actually thrown by initializing an
IndShockConsumerType, setting it up, running simulate, but without having solved it.