Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple lint edits commits for dcegm.py #278

Merged
merged 2 commits into from
May 6, 2019
Merged

Conversation

rsaavy
Copy link
Contributor

@rsaavy rsaavy commented May 6, 2019

it still gets
dcegm.py:155:25: E712 comparison to False should be 'if cond is False:' or 'if not cond:' dcegm.py:161:26: E712 comparison to False should be 'if cond is False:' or 'if not cond:' dcegm.py:175:50: E712 comparison to False should be 'if cond is False:' or 'if not cond:'

@llorracc
Copy link
Collaborator

llorracc commented May 6, 2019

I think we'd better leave this for @pkofod's judgment tomorrow. Thanks!

@llorracc llorracc requested a review from pkofod May 6, 2019 21:10
@shaunagm
Copy link
Contributor

shaunagm commented May 6, 2019

I'm going to go ahead and merge it. I'll flag it so we can follow up and fix the last E712 errors once we hear back from Patrick.

@shaunagm shaunagm merged commit d7cc063 into econ-ark:master May 6, 2019
@llorracc
Copy link
Collaborator

llorracc commented May 6, 2019

OK, sounds good.

@pkofod
Copy link
Contributor

pkofod commented May 7, 2019

Thanks! Wrt the other things, I'd have to check first that it works with numpy arrays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants