Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove employment accounting lines #1473

Merged
merged 2 commits into from
Jul 13, 2024
Merged

Conversation

Mv77
Copy link
Contributor

@Mv77 Mv77 commented Jul 13, 2024

Two lines that were added to the income process of consindshock for cstwMPC are now causing trouble. See #984 and #1182.

This PR removes those lines. This does not break anything within HARK itself.

  • Tests for new functionality/models or Tests to reproduce the bug-fix in code.
  • Updated documentation of features that add new functionality.
  • Update CHANGELOG.md with major/minor changes.

@Mv77
Copy link
Contributor Author

Mv77 commented Jul 13, 2024

I imagine this might break the compatibility of the cstwMPC REMARK with the current version of HARK. However, it is also my understanding that REMARKs are now properly pinned to a specific version of HARK, so this should not be an issue.

@mnwhite
Copy link
Contributor

mnwhite commented Jul 13, 2024 via email

@Mv77
Copy link
Contributor Author

Mv77 commented Jul 13, 2024

Hah thanks. I take that as your approval and so I'll merge this in.

@Mv77 Mv77 merged commit d5c1e20 into econ-ark:master Jul 13, 2024
15 checks passed
@Mv77 Mv77 deleted the plumbing/rm-EmpNow branch July 18, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the way we keep track of 'employment' EmpNow in IndShockConsumerType ?
2 participants