Expand SSJ exposition #1456
Merged
Expand SSJ exposition #1456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has more words and cleaner notation, but I feel like it needs more content. The entire crux of the method is the fake news algorithm, but it's not explained at all.
Added explanations and context to SSJ-example.ipynb, but had to stop when I got to the SSJ stuff. I don't know what it's doing or how it works.
Merge Will's added cells into expanded SSJ example
Added a few labels, revised default dictionary. One test might fail, will change target values.
3 tasks
Default dictionary for NK consumers changed on previous commit, so test values changed. What's more concerning is that a bunch of econforge.interp tests are failing now too.
|
Test targets have been adjusted, and numba version has been pinned below 0.60.0 (from master branch). |
|
This branch will be merged once tests finish running. The only failure before was due to a last minute variable name change that was missed, causing the final two cells of a notebook to not execute. Tomorrow morning I will release HARK 0.15.1 so that the SSJ example(s) are in public HARK for CEF and Chris's presentation before CEF. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves and extends the SSJ notebooks. It includes work from Will Du (already merged in from his branch).
As of this moment, there's a tiny bit more to do.