Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update KinkedRconsumerType.ipynb #1362

Merged
merged 4 commits into from
Mar 2, 2024

Conversation

sidd3888
Copy link
Collaborator

Made typo and LaTeX environment changes as usual. Link to the paper detailing the underlying theory was broken, so I linked the AER and NBER websites hosting the published version and its expanded edition instead. If there is some alternate link on the JHU website, which you would want to use instead, I can make the change.

CC: @llorracc @alanlujan91

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6aed7cc) 73.02% compared to head (fc93dcc) 73.02%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1362   +/-   ##
=======================================
  Coverage   73.02%   73.02%           
=======================================
  Files          79       79           
  Lines       13377    13377           
=======================================
  Hits         9769     9769           
  Misses       3608     3608           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alanlujan91
Copy link
Member

@sidd3888 the text "\verb" seems to show up in the notebook preview, is this a bug?

@sidd3888
Copy link
Collaborator Author

@alanlujan91 Yes, I have changed that on my local repo... I'll push the changes here in just a bit. By the way, where can I see the preview, as I am currently just relying on compatibility across multiple IDEs

@sidd3888
Copy link
Collaborator Author

@alanlujan91 is the \verb still visible on the preview? I looked at the notebook on all possible platforms, barring the preview you mentioned. If it is still the case, please let me know where I can see this preview? Thanks.

@alanlujan91 alanlujan91 self-requested a review December 27, 2023 17:19
@alanlujan91 alanlujan91 merged commit b2dccab into econ-ark:master Mar 2, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants