Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linting action to run pre-commit #1357

Merged
merged 7 commits into from
Nov 7, 2023

Conversation

MridulS
Copy link
Member

@MridulS MridulS commented Nov 7, 2023

This PR, add a new action which will run pre-commit on every PR. This should address #1340

I have also run pre-commit all across the code.

This PR also moves to start using ruff but just for notebooks right now. I have removed the jupytext pre-commit hook.

@MridulS MridulS requested a review from alanlujan91 November 7, 2023 15:51
@MridulS
Copy link
Member Author

MridulS commented Nov 7, 2023

0d8c7f9 is the action file.

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (3ec3404) 73.02% compared to head (78f0af8) 73.02%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1357   +/-   ##
=======================================
  Coverage   73.02%   73.02%           
=======================================
  Files          79       79           
  Lines       13377    13377           
=======================================
  Hits         9769     9769           
  Misses       3608     3608           
Files Coverage Δ
HARK/Calibration/Income/tests/test_IncomeTools.py 100.00% <ø> (ø)
HARK/ConsumptionSaving/ConsAggShockModel.py 89.68% <ø> (ø)
HARK/ConsumptionSaving/ConsPrefShockModel.py 79.68% <ø> (ø)
HARK/ConsumptionSaving/ConsRiskyContribModel.py 79.81% <ø> (ø)
...nsumptionSaving/tests/test_IndShockConsumerType.py 79.18% <100.00%> (ø)
...K/ConsumptionSaving/tests/test_SmallOpenEconomy.py 100.00% <ø> (ø)
HARK/core.py 87.71% <100.00%> (ø)
HARK/mat_methods.py 27.14% <100.00%> (ø)
HARK/model.py 0.00% <ø> (ø)
HARK/tests/test_mat_methods.py 100.00% <100.00%> (ø)
... and 1 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MridulS
Copy link
Member Author

MridulS commented Nov 7, 2023

@alanlujan91 ready for review :)

@alanlujan91 alanlujan91 linked an issue Nov 7, 2023 that may be closed by this pull request
Copy link
Member

@alanlujan91 alanlujan91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@alanlujan91 alanlujan91 merged commit ab14825 into econ-ark:master Nov 7, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pre-commit.ci
2 participants