Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in recently merged PR #1253

Merged
merged 2 commits into from
Apr 5, 2023
Merged

Conversation

Mv77
Copy link
Contributor

@Mv77 Mv77 commented Apr 4, 2023

The PR with idiosyncratic risky return draws (#1250) had a typo: riksy instead of risky.

This PR fixes the typo

  • Tests for new functionality/models or Tests to reproduce the bug-fix in code.
  • Updated documentation of features that add new functionality.
  • Update CHANGELOG.md with major/minor changes.

@alanlujan91
Copy link
Member

@Mv77 changelog also has it misspelled

@Mv77
Copy link
Contributor Author

Mv77 commented Apr 4, 2023

@Mv77 changelog also has it misspelled

haha yeah, just fixed it. Thanks for the attention to detail!

@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (9dbf39a) 73.31% compared to head (2c6e26a) 73.31%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1253   +/-   ##
=======================================
  Coverage   73.31%   73.31%           
=======================================
  Files          76       76           
  Lines       12548    12548           
=======================================
  Hits         9199     9199           
  Misses       3349     3349           
Impacted Files Coverage Δ
HARK/ConsumptionSaving/ConsRiskyAssetModel.py 40.74% <100.00%> (ø)
...ConsumptionSaving/tests/test_ConsPortfolioModel.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Mv77 Mv77 merged commit 80d027d into econ-ark:master Apr 5, 2023
@Mv77 Mv77 deleted the plumbing/idio-Rrisky branch April 15, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants