Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing unused old Mtp1 code, fixes #596 #1212

Merged
merged 1 commit into from
Jan 13, 2023
Merged

Conversation

sbenthall
Copy link
Contributor

@sbenthall sbenthall commented Jan 13, 2023

Addresses #596

Removes IndShockConsumerType.Ex_Mtp1_over_Ex_Ptp1 and IndShockConsumerType.Ex_mtp1
This code crashes when executed and is neither documented nor up to style standards.

  • Tests for new functionality/models or Tests to reproduce the bug-fix in code.
  • Updated documentation of features that add new functionality.
  • Update CHANGELOG.md with major/minor changes.

@sbenthall sbenthall added the Ready-To-Merge Has been reviewed and when branch is updated and checks pass it should be merged label Jan 13, 2023
@codecov-commenter
Copy link

Codecov Report

Base: 73.28% // Head: 73.34% // Increases project coverage by +0.06% 🎉

Coverage data is based on head (26a172b) compared to base (8313ec5).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1212      +/-   ##
==========================================
+ Coverage   73.28%   73.34%   +0.06%     
==========================================
  Files          74       74              
  Lines       12143    12130      -13     
==========================================
- Hits         8899     8897       -2     
+ Misses       3244     3233      -11     
Impacted Files Coverage Δ
HARK/ConsumptionSaving/ConsIndShockModel.py 87.24% <ø> (+0.84%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sbenthall sbenthall merged commit 2fbfbc6 into econ-ark:master Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready-To-Merge Has been reviewed and when branch is updated and checks pass it should be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants