Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine labeled distributions #1191

Merged
merged 5 commits into from
Dec 7, 2022

Conversation

Mv77
Copy link
Contributor

@Mv77 Mv77 commented Dec 5, 2022

Augments the existing combine_indep_dstns to take and use labeled distributions. If all the inputs are of the class DiscreteDistributionLabeled, the result will be another labeled discrete distribution with the labels of the variables in the original distributions.

Addresses #1190

  • Tests for new functionality/models or Tests to reproduce the bug-fix in code.
  • Updated documentation of features that add new functionality.
  • Update CHANGELOG.md with major/minor changes.

@Mv77 Mv77 linked an issue Dec 5, 2022 that may be closed by this pull request
@Mv77 Mv77 requested a review from alanlujan91 December 5, 2022 19:49
@Mv77 Mv77 added Needs: Revision Function: Distributions Ready-To-Merge Has been reviewed and when branch is updated and checks pass it should be merged labels Dec 5, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 73.56% // Head: 73.62% // Increases project coverage by +0.06% 🎉

Coverage data is based on head (7814af1) compared to base (cfaaf25).
Patch coverage: 96.96% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1191      +/-   ##
==========================================
+ Coverage   73.56%   73.62%   +0.06%     
==========================================
  Files          72       72              
  Lines       11941    11973      +32     
==========================================
+ Hits         8784     8815      +31     
- Misses       3157     3158       +1     
Impacted Files Coverage Δ
HARK/distribution.py 82.80% <93.75%> (+0.32%) ⬆️
HARK/tests/test_distribution.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alanlujan91 alanlujan91 merged commit 86d5c62 into econ-ark:master Dec 7, 2022
@Mv77 Mv77 deleted the plumbing/combine-labeled branch July 5, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Function: Distributions Needs: Revision Ready-To-Merge Has been reviewed and when branch is updated and checks pass it should be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Combining labeled distributions
3 participants