Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure examples/ are all working #943

Closed
sbenthall opened this issue Feb 7, 2021 · 3 comments · Fixed by #944
Closed

Make sure examples/ are all working #943

sbenthall opened this issue Feb 7, 2021 · 3 comments · Fixed by #944
Assignees
Milestone

Comments

@sbenthall
Copy link
Contributor

I believe that making sure examples/ are working is part of our release cycle for HARK, but it's not currently part of the automated test regimen.

At the time of this writing, it looks like not all of the examples/ are functioning.

It is especially important to have them all working for the 1.0 release.

@sbenthall sbenthall added this to the 1.0.0 milestone Feb 7, 2021
sbenthall added a commit to sbenthall/HARK that referenced this issue Feb 9, 2021
sbenthall added a commit to sbenthall/HARK that referenced this issue Feb 9, 2021
@sbenthall sbenthall mentioned this issue Feb 9, 2021
@sbenthall sbenthall assigned sbenthall and MridulS and unassigned sbenthall Feb 14, 2021
@sbenthall
Copy link
Contributor Author

reassigning to Mridul because you seem to be working on it with #944 ?

@MridulS
Copy link
Member

MridulS commented Feb 18, 2021

for reference, broken examples (mostly because of Now)

  • examples/ConsIndShockModel/IndShockConsumerType.py
  • examples/ConsIndShockModel/PerfForesightConsumerType.py
  • examples/ConsumptionSaving/example_ConsMedModel.py
  • examples/ConsumptionSaving/example_TractableBufferStockModel.py
  • examples/ConsumptionSaving/example_ConsPortfolioModel.py
  • examples/ConsumptionSaving/example_ConsMarkovModel.py
  • examples/ConsumptionSaving/example_ConsRepAgentModel.py
  • examples/ConsumptionSaving/example_ConsGenIncProcessModel.py
  • examples/ConsumptionSaving/example_ConsPrefShockModel.py
  • examples/FashionVictim/FashionVictimModel.py
  • examples/GenIncProcessModel/GenIncProcessModel.py
  • examples/HowWeSolveIndShockConsumerType/HowWeSolveIndShockConsumerType.py

@sbenthall
Copy link
Contributor Author

I'm confused why we are support these .py examples. Most of our examples are notebooks. For some reason, these .py files are not Jupyter linked with the corresponding notebooks? Why are we maintaining them like this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants