Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constructor for lognormal distribution that takes average and variance #637

Closed
sbenthall opened this issue Apr 21, 2020 · 1 comment · Fixed by #891
Closed

Constructor for lognormal distribution that takes average and variance #637

sbenthall opened this issue Apr 21, 2020 · 1 comment · Fixed by #891

Comments

@sbenthall
Copy link
Contributor

See #519 and #611

In ConsPortfolioModel (and possibly elsewhere), there are places where there is duplicate code computing a Log Normal mu and sigma from a given average and variance.

https://github.com/econ-ark/HARK/blob/master/HARK/ConsumptionSaving/ConsPortfolioModel.py#L243-L261

Rather than doing this twice in the model code, it would be better to have an alternative constructor for the lognormal distribution that took these values directly.

@sbenthall sbenthall added this to the 1.0.0 milestone Apr 21, 2020
@sbenthall
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant