-
-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
always adding 'solution' to timeVary? #573
Comments
No, it should be in time_vary no matter what. An infinite horizon problem
might have more than one period, so solution will be a list with more than
one element. When timeFlip() is executed, we want that list to be
reversed().
After you remove all the timeFlip stuff, then there's no point in solution
being named in time_vary. It's not used as a solver input, and time will
never be reversed for an AgentType.
…On Mon, Mar 16, 2020 at 5:07 PM Sebastian Benthall ***@***.***> wrote:
In this line in solve(), the recently formed solution is added to the
time varying parameter list.
https://github.com/econ-ark/HARK/blob/master/HARK/core.py#L386
I may be mistaken here, but I think that in an infinite horizon model, it
should not be time-varying.
Is that right?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#573>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADKRAFO33PLNCTET77CABUTRH2IILANCNFSM4LMVLZQA>
.
|
Is |
Yes. solve() and the functions it calls need to know whether a particular
argument for solveOnePeriod is time-varying or time-invariant, and thus
whether to pass the entire attribute as the argument or just grab one
particular index from the list.
It can't just look at whether each element is a list, because sometimes the
value for one particular period *is* a list.
…On Tue, Mar 17, 2020 at 10:53 AM Sebastian Benthall < ***@***.***> wrote:
Is time_vary used for anything besides the timeFlip stuff?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#573 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADKRAFIM26CHFFIK75ULEITRH6FHHANCNFSM4LMVLZQA>
.
|
Ok. If I understand correctly, 'time_vary' is involved only with the solution logic. It is not part of the simulation logic. Is that correct? |
That's correct, as far as I know.
…On Tue, Mar 17, 2020 at 11:01 AM Sebastian Benthall < ***@***.***> wrote:
Ok. If I understand correctly, 'time_vary' is involved only with the
solution logic.
It is not part of the simulation logic.
Is that correct?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#573 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADKRAFPWZQHADW5ZLSVBDTTRH6GEBANCNFSM4LMVLZQA>
.
|
Ok, this ticket is now fixed in a commit in PR #570 , which is ready for your review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In this line in
solve()
, the recently formed solution is added to the time varying parameter list.https://github.com/econ-ark/HARK/blob/master/HARK/core.py#L386
I may be mistaken here, but I think that in an infinite horizon model, it should not be time-varying.
Is that right?
The text was updated successfully, but these errors were encountered: