Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always adding 'solution' to timeVary? #573

Closed
sbenthall opened this issue Mar 16, 2020 · 6 comments
Closed

always adding 'solution' to timeVary? #573

sbenthall opened this issue Mar 16, 2020 · 6 comments

Comments

@sbenthall
Copy link
Contributor

In this line in solve(), the recently formed solution is added to the time varying parameter list.

https://github.com/econ-ark/HARK/blob/master/HARK/core.py#L386

I may be mistaken here, but I think that in an infinite horizon model, it should not be time-varying.
Is that right?

@mnwhite
Copy link
Contributor

mnwhite commented Mar 17, 2020 via email

@sbenthall
Copy link
Contributor Author

Is time_vary used for anything besides the timeFlip stuff?

@mnwhite
Copy link
Contributor

mnwhite commented Mar 17, 2020 via email

@sbenthall
Copy link
Contributor Author

Ok. If I understand correctly, 'time_vary' is involved only with the solution logic.

It is not part of the simulation logic.

Is that correct?

@mnwhite
Copy link
Contributor

mnwhite commented Mar 17, 2020 via email

@sbenthall
Copy link
Contributor Author

Ok, this ticket is now fixed in a commit in PR #570 , which is ready for your review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants